Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Disable autoupdate on windows installer #907

Merged
merged 4 commits into from
Oct 5, 2018

Conversation

HappyTobi
Copy link
Contributor

[NEW] Allow setup to disable autoupdate

Closes #849

you can run the installer with the option "/disableAutoUpdates" to disable the update function in rocket.chat (like the windows App Store version)

@tassoevan tassoevan merged commit 0e0beb6 into RocketChat:develop Oct 5, 2018
@Anguel
Copy link

Anguel commented Oct 11, 2018

/disableAutoUpdates does not seem to work for me on Windows 10, "Check updates on Start is still checked". Did uninstall and reinstall, same problem.

@nexidus
Copy link

nexidus commented Oct 11, 2018

I have installed it on a W10 1809 VM over the existing 2.13.3 and it worked. No checkbox for updated.

image

@Anguel
Copy link

Anguel commented Oct 11, 2018

I run the installer with: /S /allusers /disableAutoUpdates
grafik

EDIT: Tested on multiple PCs, same issue.

@josephbadow
Copy link

I'm facing the same problem, rocket.chat is still offering to check for updates. I tried several ways but all ended up the same:

Updated an existing 2.13.3

  • Quit rocket.chat Client
  • rocketchat-setup-2.14.0.exe /S /allusers /disableAutoUpdates
  • Open rocket.chat Client
  • AutoUpdate still enabled

Fresh installation

  • Uninstalled 2.14.0
  • Removed %appdata%\Rocket.Chat
  • rocketchat-setup-2.14.0.exe /S /allusers /disableAutoUpdates
  • Open rocket.chat Client
  • AutoUpdate still enabled

It seems that the update.json file at %appdata%\Rocket.Chat is not created.

I created it manually with

{
	"canUpdate":false,
	"autoUpdate":false
}

and this removed the Update options in the about dialog.

@HappyTobi
Copy link
Contributor Author

HappyTobi commented Oct 11, 2018

I will check that, i think we need an other installer option to copy the settings to all users.

For single users it works like expected

@nexidus
Copy link

nexidus commented Oct 11, 2018

My command is without /allusers. Only /s /disableAutoUpdates
Maybe the /allusers command are the problem?

@HappyTobi
Copy link
Contributor Author

I think so

@havx
Copy link

havx commented Oct 12, 2018

Copying the settings to "all users" during install does not work in an enterprise deployment since it would only apply to existing users on the machine. The application should honor update.json in the installation directory like servers.json, overriding what may be found in %appdata%\Rocket.Chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants