Skip to content

Commit

Permalink
Message render performance (#880)
Browse files Browse the repository at this point in the history
- Refactored Message component to use React.memo and re-render only what's necessary
- Added a test mode to toggle markdown parse by long press drawer (it'll be removed in the next release)
  • Loading branch information
diegolmello authored and marceloschmidt committed Jun 6, 2019
1 parent 59aa6ca commit 3db6e36
Show file tree
Hide file tree
Showing 13,822 changed files with 2,718,248 additions and 19,726 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
50 changes: 21 additions & 29 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

e2e-test:
macos:
xcode: "10.1.0"
xcode: "10.2.1"

environment:
BASH_ENV: "~/.nvm/nvm.sh"
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
android-build:
<<: *defaults
docker:
- image: circleci/android:api-28-node8-alpha
- image: circleci/android:api-28-node

environment:
# GRADLE_OPTS: -Dorg.gradle.jvmargs="-Xmx4096m -XX:+HeapDumpOnOutOfMemoryError"
Expand Down Expand Up @@ -131,24 +131,18 @@ jobs:
echo -e "VERSIONCODE=$CIRCLE_BUILD_NUM" >> ./gradle.properties
if [[ $FABRIC_KEY ]]; then
echo -e "" > ./app/fabric.properties
echo -e "apiKey=$FABRIC_KEY" >> ./app/fabric.properties
echo -e "apiSecret=$FABRIC_SECRET" >> ./app/fabric.properties
fi
- run:
name: Install Android Depedencies
name: Set Google Services
command: |
cd android
./gradlew androidDependencies
cd android/app
cp google-services.prod.json google-services.json
- run:
name: Build Android App
command: |
cd android
if [[ $KEYSTORE ]]; then
./gradlew assembleRelease
./gradlew bundleRelease
else
./gradlew assembleDebug
fi
Expand All @@ -172,7 +166,7 @@ jobs:

ios-build:
macos:
xcode: "10.1.0"
xcode: "10.2.1"

environment:
BASH_ENV: "~/.nvm/nvm.sh"
Expand Down Expand Up @@ -201,25 +195,18 @@ jobs:
command: |
yarn
# - run:
# name: Fix known build error
# command: |
# # Fix error https://github.com/facebook/react-native/issues/14382
# cd node_modules/react-native/scripts/
# curl https://raw.githubusercontent.com/facebook/react-native/5c53f89dd86160301feee024bce4ce0c89e8c187/scripts/ios-configure-glog.sh > ios-configure-glog.sh
# chmod +x ios-configure-glog.sh
- run:
name: Set Google Services
command: |
cd ios
cp GoogleService-Info.prod.plist GoogleService-Info.plist
- run:
name: Fastlane Build
no_output_timeout: 1200
command: |
cd ios
agvtool new-version -all $CIRCLE_BUILD_NUM
/usr/libexec/PlistBuddy -c "Set Fabric:APIKey $FABRIC_KEY" ./RocketChatRN/Info.plist
if [[ $FABRIC_KEY ]]; then
echo -e > "./Fabric.framework/run $FABRIC_KEY $FABRIC_SECRET" > ./RocketChatRN/Fabric.sh
fi
if [[ $MATCH_KEYCHAIN_NAME ]]; then
fastlane ios release
Expand All @@ -240,7 +227,7 @@ jobs:

ios-testflight:
macos:
xcode: "10.1.0"
xcode: "10.2.1"

steps:
- checkout
Expand All @@ -266,9 +253,14 @@ workflows:
build-and-test:
jobs:
- lint-testunit
# - e2e-test:
# requires:
# - lint-testunit

- e2e-hold:
type: approval
requires:
- lint-testunit
- e2e-test:
requires:
- e2e-hold

- ios-build:
requires:
Expand Down
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ module.exports = {
"new-cap": [2],
"use-isnan": 2,
"valid-typeof": 2,
"linebreak-style": [2, "unix"],
"linebreak-style": 0,
"prefer-template": 2,
"template-curly-spacing": [2, "always"],
"quotes": [2, "single"],
Expand Down
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,9 @@ Readme will guide you on how to config.
## Current priorities
1) [NEW] Jitsi integration ([#711][i711])
2) [NEW] Federation ([#706][i706])
3) [NEW] Threads ([#707][i707])
4) [NEW] Record video ([#712][i712])
5) [NEW] Slash Commands ([#405][i405])
6) [NEW] Draft message per room ([#708][i708])
7) [NEW] Share extension ([#391][i391])
3) [NEW] Record video ([#712][i712])
4) [NEW] Slash Commands ([#405][i405])
5) [NEW] Share extension ([#391][i391])
[i711]: https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/711
[i706]: https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/706
Expand All @@ -80,11 +78,11 @@ Readme will guide you on how to config.
|--------------------------------------------------------------- |-------- |
| Jitsi Integration | ❌ |
| Federation (Directory) | ❌ |
| Threads | |
| Threads | |
| Record Audio | ✅ |
| Record Video | ❌ |
| Commands | ❌ |
| Draft message per room | |
| Draft message per room | |
| Share Extension | ❌ |
| Notifications Preferences | ✅ |
| Edited status | ✅ |
Expand All @@ -102,7 +100,7 @@ Readme will guide you on how to config.
| Theming | ❌ |
| Settings -> Review the App | ❌ |
| Settings -> Default Browser | ❌ |
| Admin panel | |
| Admin panel | |
| Reply message from notification | ❌ |
| Unread counter banner on message list | ✅ |
| E2E | ❌ |
Expand Down
Loading

0 comments on commit 3db6e36

Please sign in to comment.