[NEW] Save to camera roll #1439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have put the 'save-to-gallery' feild in i18n en.js file, the gif is not updated with that |
|
@Prateek93a Thanks. I'll review it soon. |
|
@diegolmello Thanks |
djorkaeffalexandre
requested changes
Dec 13, 2019
android/app/src/main/java/chat/rocket/reactnative/MainApplication.java
Outdated
Show resolved
Hide resolved
|
@Prateek93a We're having trouble with React Native's Modal implementation. |
|
@diegolmello Great, looking forward to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #888
I have implemented save-to-album function. Currently I am using toast, which has an issue that the toast appears below the image modal, so one has to close the image modal to view the toast message