Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Presence Cap #4900

Merged
merged 14 commits into from
Feb 14, 2023
Merged

[NEW] Presence Cap #4900

merged 14 commits into from
Feb 14, 2023

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Feb 9, 2023

Proposed changes

RocketChat/Rocket.Chat#27854
RocketChat/Rocket.Chat#27933

  • Missing URL to docs

Issue(s)

How to test or reproduce

Note: Ignore the setting. It's just to show the value changing on the backend.

2023-02-09.15-37-37.mp4
2023-02-09.15-33-48.mp4
2023-02-09.15-32-26.mp4

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-271

@dnlsilva dnlsilva marked this pull request as ready for review February 13, 2023 18:19
@diegolmello diegolmello added this pull request to the merge queue Feb 14, 2023
@diegolmello diegolmello removed this pull request from the merge queue due to the queue being cleared Feb 14, 2023
@diegolmello diegolmello merged commit 8c47187 into develop Feb 14, 2023
@diegolmello diegolmello deleted the new.presence-cap branch February 14, 2023 13:47
diegolmello added a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants