Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Action sheet closing whenever an input is focused #5842

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: Action sheet closing whenever an input is focused #5842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e427d08
Fix action sheet closing whenever an input is focused https://github.…
diegolmello Aug 27, 2024
b3b95e6
Refresh CI cache
diegolmello Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
"@types/bytebuffer": "^5.0.44",
"@types/ejson": "^2.1.3",
"@types/i18n-js": "^3.8.3",
"@types/invariant": "^2.2.37",
"@types/invariant": "2.2.37",
"@types/jest": "^29.5.12",
"@types/jsrsasign": "^10.5.8",
"@types/lodash": "^4.14.188",
Expand Down
14 changes: 14 additions & 0 deletions patches/@discord+bottom-sheet+4.6.1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
diff --git a/node_modules/@discord/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx b/node_modules/@discord/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
index 2897fef..9a8505e 100644
--- a/node_modules/@discord/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
+++ b/node_modules/@discord/bottom-sheet/src/components/bottomSheet/BottomSheet.tsx
@@ -1382,7 +1382,8 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
if (containerHeight !== _previousContainerHeight) {
animationSource = ANIMATION_SOURCE.CONTAINER_RESIZE;
animationConfig = {
- duration: 0,
+ // https://github.com/gorhom/react-native-bottom-sheet/pull/1497
+ duration: 1,
};
}
}
diff --git a/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx b/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx
index 2219e0f..59f90ba 100644
--- a/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4317,7 +4317,7 @@
resolved "https://registry.yarnpkg.com/@types/i18n-js/-/i18n-js-3.8.9.tgz#074d1389539d2db992e6afd7eb379aa02929ef93"
integrity sha512-bSxgya4x5O+x+QhfCGckiDDE+17XGPp1TNBgBA/vfF5EwdiZC70F4cKG5QK2v44+v62oY7/t/InreRhxskulcA==

"@types/invariant@^2.2.37":
"@types/invariant@2.2.37":
version "2.2.37"
resolved "https://registry.yarnpkg.com/@types/invariant/-/invariant-2.2.37.tgz#1709741e534364d653c87dff22fc76fa94aa7bc0"
integrity sha512-IwpIMieE55oGWiXkQPSBY1nw1nFs6bsKXTFskNY8sdS17K24vyEBRQZEwlRS7ZmXCWnJcQtbxWzly+cODWGs2A==
Expand Down