Skip to content

feat: quote above user message #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diegolmello merged 13 commits into from
Sep 9, 2025
Merged

feat: quote above user message #6121

diegolmello merged 13 commits into from
Sep 9, 2025

Conversation

@OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 31, 2025

Proposed changes

Move quote above user message to looks like web/desktop.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-502

How to test or reproduce

  • open the app;
  • go to roomView;
  • quote a message;

Screenshots

Before After
Before After

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 31, 2025 21:49
@diegolmello diegolmello changed the title chore: quote above user message feat: quote above user message Mar 17, 2025
diegolmello
diegolmello requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't just a matter of moving this line above content?

@OtavioStasiak
Copy link
Contributor Author

OtavioStasiak commented Mar 17, 2025

Isn't just a matter of moving this line above content?

I don't think so because once you move attachments above the content, you're not just changing the position of the quote but also all types of attachments, such as images and videos.

diegolmello
diegolmello requested changes Sep 9, 2025
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint and missing stories

@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 15:28 — with GitHub Actions Error
@OtavioStasiak
Copy link
Contributor Author

OtavioStasiak commented Sep 9, 2025

Fix lint and missing stories

Simulator Screenshot - iPhone 16 - 2025-09-09 at 12 48 57 we already have stories for quote.

diegolmello
diegolmello requested changes Sep 9, 2025
View reviewed changes
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 16:37 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:03 — with GitHub Actions Error
diegolmello
diegolmello requested changes Sep 9, 2025
View reviewed changes
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:06 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build September 9, 2025 17:10 — with GitHub Actions Error
@diegolmello diegolmello merged commit 965ac53 into develop Sep 9, 2025
4 of 7 checks passed
@diegolmello diegolmello deleted the chore-quoted-message-above-the-user-message branch September 9, 2025 17:11
@diegolmello diegolmello had a problem deploying to experimental_android_build September 9, 2025 17:13 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_ios_build September 9, 2025 17:13 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to official_android_build September 9, 2025 17:13 — with GitHub Actions Failure
@coderabbitai coderabbitai bot mentioned this pull request Sep 23, 2025
Merged
10 tasks
diegolmello added a commit that referenced this pull request Sep 24, 2025
@diegolmello
regression: Collapsible quote not rendering after #6121 (#6677)
14b131c
OtavioStasiak pushed a commit that referenced this pull request Oct 21, 2025
@diegolmello @OtavioStasiak
regression: Collapsible quote not rendering after #6121 (#6677)
13b55db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OtavioStasiak @diegolmello