-
Notifications
You must be signed in to change notification settings - Fork 1.4k
test: use deeplink authentication #6699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
da87782
basic
Rohit3523 738c521
more changes
Rohit3523 3bca05f
more changes
Rohit3523 61cf117
chore: format code with Prettier [skip ci]
Rohit3523 c523859
trigger build
Rohit3523 a642d0e
revert
Rohit3523 4618486
upload maestro screenshots
Rohit3523 3c07c88
added create user in create room
Rohit3523 9561185
more test fix
Rohit3523 908e2c2
fix screenshot path
Rohit3523 5b1c9dc
press enter to search in join from directory
Rohit3523 5501e35
join from directory improve
Rohit3523 78c10cb
wait for room list to visible after login
Rohit3523 1c026b3
dispatch app ready after oauth login
Rohit3523 c136069
chore: format code with Prettier [skip ci]
Rohit3523 c2544a3
Merge branch 'develop' into deeplink-login-maestro
Rohit3523 413c4ea
Merge branch 'develop' into deeplink-login-maestro
Rohit3523 58c939d
Remove screenshot
Rohit3523 cff98f4
Uppercase env
Rohit3523 07a5056
use Maestro 2.0.0
Rohit3523 49c47ce
Upload maestro dir
Rohit3523 cb29e60
correct path
Rohit3523 810be28
random commit
Rohit3523 87644b3
revert
Rohit3523 8dd5d6d
log api response
Rohit3523 ec5da65
log body
Rohit3523 ff2c700
rerun
Rohit3523 60e123f
admin console
Rohit3523 4299e38
Remove logs
Rohit3523 211f905
don't upload maestro dir
Rohit3523 9afc9a0
Remove unused
Rohit3523 3341dbf
use latest maestro
Rohit3523 a9ec55e
space fix
Rohit3523 c4ed652
space fix
Rohit3523 7e01b3a
remove launch app and stop app before starting with deeplink
Rohit3523 12785cc
stop app before trying to login...
Rohit3523 87fc3e5
clear app state
Rohit3523 fc9f10e
deeplink condition for ios
Rohit3523 32e8101
added clear state env
Rohit3523 3d35940
press allow notification on all
Rohit3523 8dad0f7
change
Rohit3523 920fb66
mark optional
Rohit3523 ba4798b
nope
Rohit3523 d467442
optional
Rohit3523 17e62de
upload maestro
Rohit3523 b50c9dd
pixel launcher hide
Rohit3523 f5d81d9
remove maestro folder
Rohit3523 1faff20
Merge branch 'develop' into deeplink-login-maestro
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| appId: chat.rocket.reactnative | ||
| name: Login with Deeplink | ||
| tags: | ||
| - 'util' | ||
|
|
||
| --- | ||
| - runFlow: | ||
| when: | ||
| true: CLEAR_STATE | ||
| platform: android | ||
| commands: | ||
| - clearState | ||
| - stopApp: chat.rocket.reactnative | ||
| - evalScript: ${output.login = output.utils.login(USERNAME, PASSWORD)} | ||
| - runFlow: | ||
| file: 'open-deeplink.yaml' | ||
| env: | ||
| link: ${output.utils.getDeepLink('auth', server || output.data.server, 'userId=', output.login.userId, '&token=', output.login.authToken)} | ||
| - runFlow: | ||
| when: | ||
| platform: android | ||
| commands: | ||
| - runFlow: | ||
| when: | ||
| visible: '.*Pixel Launcher.*' | ||
| commands: | ||
| - tapOn: 'Close App' | ||
| - extendedWaitUntil: | ||
| visible: | ||
| text: '.*Allow.*' | ||
| timeout: 30000 | ||
| optional: true | ||
| - tapOn: | ||
| text: '.*Allow.*' | ||
| optional: true | ||
| - assertNotVisible: | ||
| text: '.*Allow.*' | ||
| optional: true | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: 'rooms-list-view' | ||
| timeout: 60000 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,5 +9,6 @@ tags: | |
| - runFlow: | ||
| when: | ||
| visible: '.*Open in.*' | ||
| platform: iOS | ||
| commands: | ||
| - tapOn: Open | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token in deeplink can leak in logs/artifacts; add safeguards.
Opening a URL with
authTokenrisks exposure in Maestro logs and uploaded CI artifacts. Mitigate by:I can provide a small teardown helper to revoke tokens after tests if desired.