Skip to content

fix: action sheet title font size#6705

Merged
diegolmello merged 4 commits intodevelopfrom
fix.action-sheet-item-title-default-font-size
Oct 7, 2025
Merged

fix: action sheet title font size#6705
diegolmello merged 4 commits intodevelopfrom
fix.action-sheet-item-title-default-font-size

Conversation

@OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Oct 3, 2025

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1043

How to test or reproduce

  • Open the app;
  • Go to room;
  • tap and hold a message;

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2025-10-03 at 13 59 33 Simulator Screenshot - iPhone 16 - 2025-10-03 at 13 59 57

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Style
    • Reduced ActionSheet title font size for a more balanced, consistent look across screens.
    • Enhances visual hierarchy so supporting content appears more prominent while maintaining readability.
    • No changes to behavior, layout, or interactions; only visual adjustment.
    • Users may notice a subtler header appearance in ActionSheet dialogs, aligning with the overall design system.

@OtavioStasiak OtavioStasiak temporarily deployed to approve_e2e_testing October 3, 2025 17:04 — with GitHub Actions Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

Adjusted ActionSheet title font size from 18 to 16 in app/containers/ActionSheet/styles.ts. No other style or structural changes.

Changes

Cohort / File(s) Summary
ActionSheet Styles
app/containers/ActionSheet/styles.ts
Reduced title.fontSize from 18 to 16; no other edits

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • diegolmello

Poem

A nibble of style in twilight’s hue,
I nudged the title—subtle, true.
Sixteen points now, tidy and light,
The sheet looks balanced, snug and right.
Thump-thump—rabbit hops off into the night. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “fix: action sheet title font size” succinctly and accurately describes the primary change of reducing the action sheet title font size, follows a clear conventional commit style, and does not include extraneous details.
Linked Issues Check ✅ Passed The pull request directly addresses issue NATIVE-1043 by reducing the default action sheet title font size from 18 to 16 as specified, and no other coding objectives were required by the linked issue.
Out of Scope Changes Check ✅ Passed All modifications are confined to the ActionSheet styles file and solely adjust the title font size, with no unrelated or extraneous changes introduced outside the scope of the linked issue.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix.action-sheet-item-title-default-font-size

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between baffc7b and bb440ca.

📒 Files selected for processing (1)
  • app/containers/ActionSheet/styles.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/containers/ActionSheet/styles.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build October 3, 2025 17:08 — with GitHub Actions Error
@OtavioStasiak OtavioStasiak marked this pull request as ready for review October 3, 2025 19:41
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_android_build October 7, 2025 16:30 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to official_android_build October 7, 2025 16:30 — with GitHub Actions Failure
@OtavioStasiak OtavioStasiak had a problem deploying to experimental_ios_build October 7, 2025 16:30 — with GitHub Actions Failure
@diegolmello diegolmello merged commit 056484f into develop Oct 7, 2025
5 of 10 checks passed
@diegolmello diegolmello deleted the fix.action-sheet-item-title-default-font-size branch October 7, 2025 16:31
OtavioStasiak added a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants