Skip to content

chore: remove maestro test recording from action#6769

Closed
Rohit3523 wants to merge 2 commits intodevelopfrom
android-test-record
Closed

chore: remove maestro test recording from action#6769
Rohit3523 wants to merge 2 commits intodevelopfrom
android-test-record

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Nov 6, 2025

Proposed changes

This pull request removes the recording from maestro test done in Github action.
This will give some extra memory to android emulator and expected to run the test smooth

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Streamlined Android Maestro test workflow by removing screen recording capture and artifact upload functionality, while maintaining full test execution capability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

The Android Maestro test workflow was modified to remove screen recording functionality. The screenrecord startup, PID capture, recording stop, video file retrieval, and cleanup steps were eliminated, along with the associated artifact upload and retention configuration. Core test execution and result handling remain unchanged.

Changes

Cohort / File(s) Summary
CI/CD Workflow Updates
.github/workflows/maestro-android.yml
Removed screen recording lifecycle steps (screenrecord start, PID capture, recording stop, video pull, file deletion) and associated artifact upload configuration with retention settings

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward removal of optional workflow steps with no logic impact
  • Changes are deletions only with no new conditional branches or behavioral modifications
  • Remaining workflow structure verified intact

Suggested reviewers

  • diegolmello

Poem

🐰 The screen recordings fade to night,
No longer captured in the light,
But Maestro's tests dance on with grace,
Fast-forwarding through the workflow's race!
With simpler steps, we sprint ahead,
Less storage weight upon our thread. 🎬✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the maestro test recording from the GitHub Action workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch android-test-record

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3532447 and d8b9979.

📒 Files selected for processing (1)
  • .github/workflows/maestro-android.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/maestro-android.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build November 7, 2025 15:51 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to official_android_build November 7, 2025 15:51 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build November 7, 2025 15:51 — with GitHub Actions Failure
@Rohit3523 Rohit3523 marked this pull request as ready for review November 8, 2025 17:08
@Rohit3523 Rohit3523 requested a review from diegolmello November 8, 2025 17:08
@Rohit3523
Copy link
Contributor Author

Added this behaviour in #6831

@Rohit3523 Rohit3523 closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant