fix (android): unable to send files in E2EE channel using action menu#6919
fix (android): unable to send files in E2EE channel using action menu#6919
Conversation
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Android Build Available Rocket.Chat Experimental 4.69.0.108141 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNSw_GGb3oW1Y0nep_sPxE5MGCwUBmyP7VJu-6Oze1Y_qx0H7EIDHF955nVr14LPeMK9qVLJ4GCzS0-5DxAO |
|
Android Build Available Rocket.Chat Experimental 4.69.0.108145 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNStpldbpHMyq6le7KtRHz6nqwGviY6DgYRmdolhLdyHgT_X4d5eQgfgTaT2ti4U6GJPwpudKUZBB1j6-vGc |
diegolmello
left a comment
There was a problem hiding this comment.
It worked! Let's merge the lib, update this PR and test it again for sanity.
|
Android Build Available Rocket.Chat Experimental 4.69.0.108186 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRDvFsmpqJiNxlaWvgaM2e7l2ep92pie-pL8rgyMjAXsBmVHYuV927LUqSmbStadpe8ELRmU1SfBJG8EgUi |
Proposed changes
In the android app users were unable to send attachments using the “Choose File” option from the action button in E2EE channels.
The root cause was identified in the crypto package that we are using for encryption, files selected through the Android system picker use
content://URIs but the library incorrectly converted them tocontent:/. This caused Android to fail to locate the file, preventing users from sending attachments.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1704
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.