chore(Android): fix CI generated changelog#6922
Merged
Conversation
Contributor
WalkthroughThis pull request refactors the Android changelog preparation workflow by extracting inline truncation logic from a GitHub Action into a dedicated Node.js script that properly handles Unicode grapheme clusters. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Play Store enforces a 500 character limit for changelogs, but the existing logic was validating against 500 bytes. This allowed multibyte characters to pass the check, causing uploads to fail at release time.
This PR introduces a Node.js script that correctly counts characters and trims the changelog to a maximum of 500 characters, ensuring Play Store uploads succeed reliably.
Action Link: https://github.com/RocketChat/Rocket.Chat.ReactNative/actions/runs/21064075567
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1634
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments