Make ReactionPicker full screen with search by emoji title #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
diegolmello
requested changes
Apr 4, 2019
Codecov Report
@@ Coverage Diff @@
## develop #780 +/- ##
==========================================
Coverage ? 86.92%
==========================================
Files ? 39
Lines ? 673
Branches ? 117
==========================================
Hits ? 585
Misses ? 71
Partials ? 17
Continue to review full report at Codecov.
|
|
@IlarionHalushka Can you resolve conflicts? |
|
@diegolmello I resolved conflicts and Made a few performance improvements like: using caching of images (custom emoji), use debounce on handleSearch, remove unneeded View wrappers. Then I decided to hide frequently used if there are 0 items. Finally fixed header title, not sure why it was not displaying when I used |
diegolmello
added
👀 needs review
👍 improvement
🚨 needs changes
and removed
👀 needs review
labels
# Conflicts: # __tests__/__snapshots__/Storyshots.test.js.snap # app/containers/EmojiPicker/CustomEmoji.js # app/containers/message/Message.js # app/containers/message/index.js # app/index.js # app/views/RoomView/index.js # package.json # yarn.lock
IlarionHalushka
requested review from
diegolmello,
pranavpandey1998official and
djorkaeffalexandre
diegolmello
requested changes
Jun 27, 2019
| @@ -1,12 +1,12 @@ | |||
| import React from 'react'; | |||
| import { Image } from 'react-native'; | |||
| import { ViewPropTypes, Image } from 'react-native'; | |||
| @@ -33,7 +38,7 @@ export default class EmojiCategory extends React.Component { | |||
| onEmojiSelected: PropTypes.func, | |||
| emojisPerRow: PropTypes.number, | |||
| width: PropTypes.number | |||
| } | |||
| }; | |||
| initialNumToRender={45} | ||
| getItemLayout={(data, index) => ({ length: this.size, offset: this.size * index, index })} | ||
| initialNumToRender={30} | ||
| getItemLayout={(data, index) => ({ |
| @@ -1,44 +1,56 @@ | |||
| const list = ['frequentlyUsed', 'custom', 'people', 'nature', 'food', 'activity', 'travel', 'objects', 'symbols', 'flags']; | |||
| const titles = ['FREQUENTLY USED', 'CUSTOM', 'PEOPLE', 'NATURE', 'FOOD', 'ACTIVITY', 'TRAVEL', 'OBJECTS', 'SYMBOLS', 'FLAGS']; | |||
| @@ -94,12 +97,12 @@ export default class EmojiPicker extends Component { | |||
| database.write(() => { | |||
| database.create('frequentlyUsedEmoji', emoji, true); | |||
| }); | |||
| }) | |||
| }); | |||
| OnboardingView: { | ||
| screen: OnboardingView, | ||
| header: null | ||
| const OutsideStack = createStackNavigator( |
| @@ -110,6 +121,12 @@ const ChatsStack = createStackNavigator({ | |||
| SearchMessagesView, | |||
| SelectedUsersView, | |||
| ThreadMessagesView, | |||
| ReactionPickerView: { | |||
| screen: ReactionPickerView, | |||
| navigationOptions: { | |||
There was a problem hiding this comment.
Do it on the ReactionPickerView
| }, { | ||
| defaultNavigationOptions: defaultHeader | ||
| }); | ||
| const NewMessageStack = createStackNavigator( |
| initialRouteName: 'AuthLoading' | ||
| } | ||
| )); | ||
| const App = createAppContainer( |
| @@ -17,7 +16,15 @@ export default function messages(state = initialState, action) { | |||
| return { | |||
| ...state, | |||
| showActions: true, | |||
| actionMessage: action.actionMessage | |||
| actionMessage: { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #765
Hi @diegolmello ! This is my first PR that fixes the issue "ReactionsPicker should be full screen" including search by emoji title.
Screenshot IOS: http://prntscr.com/n72mjg
Screenshot Android: http://prntscr.com/n73fbg
Video: https://drive.google.com/file/d/1UY7I5eWg5X60i_nCdQtjsnJ2FlTqqQKO/view?usp=sharing