fix issue 840 [BUG] Profile View inputs state sets to default every 5 secs #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #840
Video after fix:
https://drive.google.com/file/d/1060_C7yYeMTYkPxZwbgUKGl6HNzQUvVe/view?usp=sharing
With PR #762 a new functionality was added to /lib/rocketchat.js where new subscription was added:
this.sdk.subscribe('activeUsers')
triggered every 5 secs. So the props of ProfileView were updating -->> which updated the state every 5 secs to defaults.The actual root cause was in
componentWillReceiveProps
method which checked for props objects equality with!==
.