refactor: omnichannel unit tests

RocketChat · Oct 31, 2024 · 346a0f0 · 346a0f0
1 parent e72ade5
commit 346a0f0
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/apps/meteor/tests/e2e/omnichannel/omnichannel-units.spec.ts b/apps/meteor/tests/e2e/omnichannel/omnichannel-units.spec.ts
@@ -75,10 +75,8 @@ test.describe('OC - Manage Units', () => {
 			await poOmnichannelUnits.btnSave.click();
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
 
-			await test.step('expect unit to have been created', async () => {
-				await poOmnichannelUnits.search(unitName);
-				await expect(poOmnichannelUnits.findRowByName(unitName)).toBeVisible();
-			});
+			await poOmnichannelUnits.search(unitName);
+			await expect(poOmnichannelUnits.findRowByName(unitName)).toBeVisible();
 		});
 
 		await test.step('expect to delete unit', async () => {
@@ -115,9 +113,6 @@ test.describe('OC - Manage Units', () => {
 			await poOmnichannelUnits.inputName.fill(editedUnitName);
 			await poOmnichannelUnits.btnSave.click();
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
-		});
-
-		await test.step('expect unit to have been edited', async () => {
 			await expect(poOmnichannelUnits.inputSearch).toBeVisible();
 			await poOmnichannelUnits.search(editedUnitName);
 			await expect(poOmnichannelUnits.findRowByName(editedUnitName)).toBeVisible();
@@ -128,9 +123,7 @@ test.describe('OC - Manage Units', () => {
 			await poOmnichannelUnits.selectMonitor('user3');
 			await poOmnichannelUnits.btnSave.click();
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
-		});
 
-		await test.step('expect unit to have been edited with 2 monitors', async () => {
 			await poOmnichannelUnits.search(editedUnitName);
 			await poOmnichannelUnits.findRowByName(editedUnitName).click();
 
@@ -163,6 +156,7 @@ test.describe('OC - Manage Units', () => {
 			});
 
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
+			await expect(poOmnichannelUnits.findRowByName(editedUnitName)).not.toBeVisible();
 		});
 	});
 
@@ -187,9 +181,7 @@ test.describe('OC - Manage Units', () => {
 			await poOmnichannelUnits.selectDepartment({ name: department2.data.name, _id: department2.data._id });
 			await poOmnichannelUnits.btnSave.click();
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
-		});
 
-		await test.step('expect department to be in the chosen departments list and have title', async () => {
 			await poOmnichannelUnits.search(unit.name);
 			await poOmnichannelUnits.findRowByName(unit.name).click();
 			await expect(poOmnichannelUnits.contextualBar).toBeVisible();
@@ -207,9 +199,7 @@ test.describe('OC - Manage Units', () => {
 			await poOmnichannelUnits.selectDepartment({ name: department2.data.name, _id: department2.data._id });
 			await poOmnichannelUnits.btnSave.click();
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
-		});
 
-		await test.step('expect department to not be in the chosen departments list', async () => {
 			await poOmnichannelUnits.search(unit.name);
 			await poOmnichannelUnits.findRowByName(unit.name).click();
 			await expect(poOmnichannelUnits.contextualBar).toBeVisible();
@@ -228,6 +218,7 @@ test.describe('OC - Manage Units', () => {
 			});
 
 			await expect(poOmnichannelUnits.contextualBar).not.toBeVisible();
+			await expect(poOmnichannelUnits.findRowByName(unit.name)).not.toBeVisible();
 		});
 	});
 });