Skip to content

Commit

Permalink
fix review
Browse files Browse the repository at this point in the history
  • Loading branch information
ggazzo authored Jun 9, 2022
1 parent 6e132d7 commit 46959fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions apps/meteor/app/apps/server/communication/methods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ export class AppMethods {
return typeof this._orch !== 'undefined' && this._orch.isEnabled();
}

isLoaded(): boolean | '' | 0 | undefined {
return typeof this._orch !== 'undefined' && this._orch.isEnabled() && this._orch.isLoaded();
isLoaded(): boolean{
return Boolean(typeof this._orch !== 'undefined' && this._orch.isEnabled() && this._orch.isLoaded());
}

_addMethods(): void {
Expand Down
1 change: 0 additions & 1 deletion apps/meteor/app/apps/server/communication/uikit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ router.post('/:appId', async (req, res, next) => {

res.send(result);
} catch (e) {
console.error('ops', e);
if (e instanceof Error) res.status(500).send({ error: e.message });
else res.status(500).send({ error: e });
}
Expand Down

0 comments on commit 46959fb

Please sign in to comment.