[FIX] Exception in getSingleMessage (#12970)

* fixed the fuckfuck ok * do the doing
RocketChat · Dec 19, 2018 · 52e9bb7 · 52e9bb7
1 parent 1243125
commit 52e9bb7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/rocketchat-lib/server/methods/getSingleMessage.js b/packages/rocketchat-lib/server/methods/getSingleMessage.js
@@ -11,11 +11,13 @@ Meteor.methods({
 
 		const msg = RocketChat.models.Messages.findOneById(msgId);
 
-		if (!msg && !msg.rid) {
+		if (!msg || !msg.rid) {
 			return undefined;
 		}
 
-		Meteor.call('canAccessRoom', msg.rid, Meteor.userId());
+		if (!Meteor.call('canAccessRoom', msg.rid, Meteor.userId())) {
+			throw new Meteor.Error('error-not-allowed', 'Not allowed', { method: 'getSingleMessage' });
+		}
 
 		return msg;
 	},