fix review

RocketChat · Jun 13, 2022 · bfd7537 · bfd7537
1 parent a5e3657
commit bfd7537
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/apps/meteor/app/apps/server/communication/methods.ts b/apps/meteor/app/apps/server/communication/methods.ts
@@ -8,10 +8,9 @@ import { AppServerOrchestrator } from '../orchestrator';
 
 const waitToLoad = function (orch: AppServerOrchestrator): unknown {
 	return new Promise<void>((resolve) => {
-		let id = setInterval(() => {
+		const id = setInterval(() => {
 			if (orch.isEnabled() && orch.isLoaded()) {
 				clearInterval(id);
-				id = -1 as unknown as NodeJS.Timeout;
 				resolve();
 			}
 		}, 100);
@@ -20,10 +19,9 @@ const waitToLoad = function (orch: AppServerOrchestrator): unknown {
 
 const waitToUnload = function (orch: AppServerOrchestrator): unknown {
 	return new Promise<void>((resolve) => {
-		let id = setInterval(() => {
+		const id = setInterval(() => {
 			if (!orch.isEnabled() && !orch.isLoaded()) {
 				clearInterval(id);
-				id = -1 as unknown as NodeJS.Timeout;
 				resolve();
 			}
 		}, 100);

diff --git a/apps/meteor/app/apps/server/communication/websockets.ts b/apps/meteor/app/apps/server/communication/websockets.ts
@@ -7,18 +7,18 @@ import { SystemLogger } from '../../../../server/lib/logger/system';
 import notifications from '../../../notifications/server/lib/Notifications';
 import { AppServerOrchestrator } from '../orchestrator';
 
-export const AppEvents = Object.freeze({
-	APP_ADDED: 'app/added',
-	APP_REMOVED: 'app/removed',
-	APP_UPDATED: 'app/updated',
-	APP_STATUS_CHANGE: 'app/statusUpdate',
-	APP_SETTING_UPDATED: 'app/settingUpdated',
-	COMMAND_ADDED: 'command/added',
-	COMMAND_DISABLED: 'command/disabled',
-	COMMAND_UPDATED: 'command/updated',
-	COMMAND_REMOVED: 'command/removed',
-	ACTIONS_CHANGED: 'actions/changed',
-});
+export enum AppEvents {
+	APP_ADDED = 'app/added',
+	APP_REMOVED = 'app/removed',
+	APP_UPDATED = 'app/updated',
+	APP_STATUS_CHANGE = 'app/statusUpdate',
+	APP_SETTING_UPDATED = 'app/settingUpdated',
+	COMMAND_ADDED = 'command/added',
+	COMMAND_DISABLED = 'command/disabled',
+	COMMAND_UPDATED = 'command/updated',
+	COMMAND_REMOVED = 'command/removed',
+	ACTIONS_CHANGED = 'actions/changed',
+}
 
 export class AppServerListener {
 	private orch: AppServerOrchestrator;