Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User friendly URLS with room names and usernames instead of IDs #18

Closed
engelgabriel opened this issue May 28, 2015 · 4 comments
Closed
Assignees
Milestone

Comments

@engelgabriel
Copy link
Member

Create slugs and use them to link to rooms

@rodrigok rodrigok modified the milestone: v0.2 Jun 2, 2015
@Hosseinamraji
Copy link

how download?

@rodrigok
Copy link
Member

rodrigok commented Jun 3, 2015

@Hosseinamraji how download what?

@scottyallen
Copy link
Contributor

So, it's not immediately obvious what a room link should look like, based on what's here. As a straw man, how about:

http://rocket.chat/room/57om6EQCcFami9wuT/general

Sound reasonable?

Another option is to just use the room name, ie:

http://rocket.chat/room/general

However, this suffers the problem that if the room is renamed, the link no longer works, whereas the former you can still look up by id.

I'm going to take a crack at implementing the first suggestion, and we can tweak it in the PR if needed.

scottyallen added a commit to scottyallen/Rocket.Chat that referenced this issue Jun 5, 2015
@engelgabriel
Copy link
Member Author

We already stated to work on this, so please wait a couple is days and you
will see your second option implemented :)

Sent from Mobile

@rodrigok rodrigok modified the milestones: v0.2, v0.3 Jun 9, 2015
@engelgabriel engelgabriel modified the milestones: v0.5, v0.3 Jun 30, 2015
@engelgabriel engelgabriel changed the title Use Better URLs User friendly URLS with room names and usernames instead of IDs Jun 30, 2015
@engelgabriel engelgabriel modified the milestones: v0.5, v0.4 Jul 1, 2015
@engelgabriel engelgabriel modified the milestones: v0.5, v0.4 Jul 20, 2015
@rodrigok rodrigok modified the milestones: v0.5, v0.6 Aug 4, 2015
@marceloschmidt marceloschmidt added this to the v0.7 milestone Aug 11, 2015
@marceloschmidt marceloschmidt removed this from the v0.6 milestone Aug 11, 2015
@rodrigok rodrigok modified the milestones: v1.0, v0.7 Aug 18, 2015
@rodrigok rodrigok mentioned this issue Aug 18, 2015
rwakida added a commit that referenced this issue Aug 22, 2015
…nRoom

tracker

Bug is a side effect of User friendly URLs #18.  The commit changed Room
subscription based on room id to room name.. It created a new room
subscription, but didn't remove the old name from the RoomManager's
openedRooms cache.  Whenever the tracker ran, an 'undefined' room
was returned because the old room name was invalid.

Adds code that observes room name changes, closes the old room, and
opens the new room via the RoomManager.  There is still a small bug
where the room name changed message is not displayed to the user who changed
the name probably due to the message stream subscribing after the message was sent.
mrsimpson referenced this issue in assistify/Rocket.Chat Aug 29, 2017
#15 - Add advanced configuration options for piwik analytics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants