-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User friendly URLS with room names and usernames instead of IDs #18
Comments
how download? |
@Hosseinamraji how download what? |
So, it's not immediately obvious what a room link should look like, based on what's here. As a straw man, how about: http://rocket.chat/room/57om6EQCcFami9wuT/general Sound reasonable? Another option is to just use the room name, ie: http://rocket.chat/room/general However, this suffers the problem that if the room is renamed, the link no longer works, whereas the former you can still look up by id. I'm going to take a crack at implementing the first suggestion, and we can tweak it in the PR if needed. |
We already stated to work on this, so please wait a couple is days and you Sent from Mobile |
…nRoom tracker Bug is a side effect of User friendly URLs #18. The commit changed Room subscription based on room id to room name.. It created a new room subscription, but didn't remove the old name from the RoomManager's openedRooms cache. Whenever the tracker ran, an 'undefined' room was returned because the old room name was invalid. Adds code that observes room name changes, closes the old room, and opens the new room via the RoomManager. There is still a small bug where the room name changed message is not displayed to the user who changed the name probably due to the message stream subscribing after the message was sent.
#15 - Add advanced configuration options for piwik analytics.
Create slugs and use them to link to rooms
The text was updated successfully, but these errors were encountered: