4.7.0 regression: edit button not displayed in the first minute after sending a new message

[nicolas-guichard]

Description:

In rooms where editing is enabled and limited in time, the client does not display the edit button in the first minute after sending.
Editing by pressing the up arrow key or with other clients still work as expected. It's only a UI issue.

I think I tracked this down in messageActionDefault.ts:

return !!currentTsDiff && currentTsDiff < blockEditInMinutes;

where currentTsDiff is the difference in minutes between the current time and the message timestamp.
During the first minute, currentTsDiff is 0 hence !!currentTsDiff is false and the edit button is not displayed.

This was introduced here.

Steps to reproduce:

1. Send a message in a room with edits enabled enabled for settings.Message_AllowEditing_BlockEditInMinutes > 1.
2. Hover the message, the edit button does not appear during the first minute.

Expected behavior:

The edit button is available as soon as the message is sent.

Actual behavior:

The edit button only appears one minute later.

Server Setup Information:

• Version of Rocket.Chat Server: 4.7.0
• Operating System:
• Deployment Method:
• Number of Running Instances:
• DB Replicaset Oplog:
• NodeJS Version:
• MongoDB Version:

Client Setup Information

• Desktop App or Browser Version: Firefox 100
• Operating System: OpenSUSE

Additional context

Relevant logs:

[ankar84]

Confirm that issue on 4.7.0!

[ghost]

Same on 4.7.1

[alvarow]

Same for me.

[usefool]

Same for me - if the "block edit after ..." option is set

Workaround: set " Block Message Editing After (n) Minutes" Option to 0 (to disable it)

[saschafoerster]

Still there on 4.8.1

[danceganse]

same problem like @saschafoerster mentioned before

[danel1]

@debdutdeb @sampaiodiego This is quite "breaking" for most of our users, since they've used the edit button mostly. Also we've set a limit to disable editing after one minute - so for us the button is gone completely... This should be an easy and fast fix - please take a look at it.

[debdutdeb]

Hey, thanks for the ping. I'll look into it tonight. In the meantime if someone would like to open a PR, we'll pf course accept that too.

[danel1]

Hey, thanks for the ping. I'll look into it tonight. In the meantime if someone would like to open a PR, we'll pf course accept that too.

See #25724