Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gitlab oAuth Provider #512

Closed
engelgabriel opened this issue Aug 19, 2015 · 12 comments
Closed

Support Gitlab oAuth Provider #512

engelgabriel opened this issue Aug 19, 2015 · 12 comments
Assignees
Milestone

Comments

@engelgabriel
Copy link
Member

See http://doc.gitlab.com/ce/integration/oauth_provider.html

@RocketChat/owners maybe create a generic account package so other meteor app can use it too?

@engelgabriel engelgabriel modified the milestones: v1.0, GitLab 0.8 Aug 19, 2015
@Sing-Li Sing-Li self-assigned this Aug 23, 2015
@Sing-Li
Copy link
Member

Sing-Li commented Aug 23, 2015

Basically done.

You first get API key and secret from your own GitLab server. Do it as root, and from the Admin area to enable instance wide access - all users of your server can oauth from Rocket.Chat.

gitlab1

Then you click the oauth(2) button for GitLab on Rocket.Chat --- on the right -- we need a logo icon !

gitlab2

Rocket.Chat then pops up the oauth2 login from GitLab, and you sign in using your gitlab credentials.

gitlab3

Once you logged in, authorize Rocket.Chat to access your GitLab account.

gitlab4

And you're in.

gitlab5

You can switch back to Rocket.Chat, without logging in again, before the auth token expires.

You can also revoke the auth token from GitLab dashboard at any time.

gitlab6

It is a generic Meteor package, so good for Atmosphere publishing, and allows any Meteor app to use GitLab as an oauth2 provider.

Right now, the code is a crazy #(@(#@# mess - hooks everywhere; debug crud all over the place. I'll tidy up tomorrow and commit. After some sleep 😪

@rodrigok
Copy link
Member

Fucking awesome! 😆

@gaving
Copy link

gaving commented Aug 23, 2015

👍

@engelgabriel
Copy link
Member Author

@Sing-Li rocks! Or Rocket... I dont know.

Either way, how can we not succeed with developers likes this?

@dosire
Copy link

dosire commented Aug 23, 2015

@Sing-Li Awesome work! Our logo can be found on https://about.gitlab.com/press/

engelgabriel added a commit that referenced this issue Aug 23, 2015
initial implementation of oauth2 client support for gitlab server flow  #512
@Sing-Li
Copy link
Member

Sing-Li commented Aug 23, 2015

Thanks, guys.

I'm totally inspired by @rodrigok 's talk less, write more code that solve problems style of technical leadership 👍

NOTE:

Before #557 is done, just go to the file packages/gitlab/gitlab_common.js and change the URL to your own GitLab server.

@Sing-Li
Copy link
Member

Sing-Li commented Aug 23, 2015

While we have the attention of the GitLab pros -- please take a moment to checkout #525 and comment on what may be possible and desirable.

We want to do for GitLab (in the team server, private Internet, and Intranet environments) as much as we will for the Github ecosystem (on the Internet). Thanks.

@dosire
Copy link

dosire commented Aug 23, 2015

@Sing-Li I'm on it.

@engelgabriel engelgabriel modified the milestone: GitLab 0.8 Aug 23, 2015
@Sing-Li
Copy link
Member

Sing-Li commented Aug 23, 2015

@dosire - thank you.

@rodrigok
Copy link
Member

Thanks @Sing-Li 😸

@engelgabriel
Copy link
Member Author

image

Working on demo

@Theaxiom
Copy link

Is this documented anywhere? I can't seem to find how to enable this.

EDIT: derp -- I figured it out.

@engelgabriel engelgabriel added this to the 0.40.0 milestone Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants