Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC [$250] #933

Closed
18 of 21 tasks
rodrigok opened this issue Sep 29, 2015 · 35 comments
Closed
18 of 21 tasks

WebRTC [$250] #933

rodrigok opened this issue Sep 29, 2015 · 35 comments

Comments

@rodrigok
Copy link
Member

  • Direct call
  • Group call
  • Show all remote videos
  • Close connections on remote close
  • Fix mute in Firefox
  • Allow select the main video
  • Join an existent call
  • Option active/deative camera
  • Option to mute
  • Audio call
  • Join calls with audio only
  • Show more information about the call before accept
  • Redirect to correct room on accept
  • Auto accept call
  • Call as monitor (without local video and audio, only in direct rooms)
  • Overlay
  • Screen sharing
  • Option to disable in general settings
  • Allow to respond video calls with only audio
  • Option to disable for room
  • Button to enable auto accept calls

Start video or audio calls in direct or group rooms

captura de tela 2015-10-03 as 15 12 21

Join calls in progress

captura de tela 2015-10-03 as 15 14 00

Accept or reject audio calls

captura de tela 2015-10-03 as 15 13 47

Accept or reject video calls

captura de tela 2015-10-03 as 15 12 56

Accept or reject monitoring calls

captura de tela 2015-10-01 as 14 56 27

See all videos and click to show one bigger

captura de tela 2015-10-03 as 15 15 14

Share your screen

captura de tela 2015-10-03 as 15 15 47

Expand the UI

captura de tela 2015-10-03 as 15 16 06
captura de tela 2015-10-03 as 15 16 01

There is a $250 open bounty on this issue. Add to the bounty at Bountysource.

@cybercorey
Copy link

Hi there, I'm keen to test these new features.
I've git pulled your branch "webrtc" and built it however I cannot find anything new. I am using the same database would this have caused this?

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

no ... create a private group of a few users

@cybercorey
Copy link

I must be blind, I cannot find the option to start a video call inside a private group.

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

click on the right panel ... and click join

@cybercorey
Copy link

Ahh worked it out, i had the new copy running with a different folder name! Cheers for your Help

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

let us know if you can get 3 or more parties going ... on my LAN, I'm having some problems with the current code 😄

@cybercorey
Copy link

Will do! getting 4 on now!

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

cool. r u on a lan? any browser running on the same machine as the server?

@cybercorey
Copy link

All over wireless, all using Chrome server is running in a VM on my machine. Started lagging once the 3rd person joined

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

yes ... it would lag ... it is a mesh network where everyone connects to everyone else. But in your case, every machine is on the same 192.168.x.x subnet?

@cybercorey
Copy link

Got 4 of us on currently all working pretty smooth, yes all on the same ip range

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

cool. thanks for helping to test!

@cybercorey
Copy link

No worries, one of us left now we are unable to click on one of our streams (keeps showing someone elses)

@cybercorey
Copy link

Another note: Getting some interesting results leaving and joining again. Prompts people to join the chat while they are in the chat. Also I (A) can now see B while B can see A and C and C can see only A (seems like it was unable to obtain connections to existing group members or something haha.

@Sing-Li
Copy link
Member

Sing-Li commented Oct 2, 2015

can you please confirm that all four users have different IPs, and that the server also has different IP than all the users?

@cybercorey
Copy link

Yup, all IP address's were different

@rodrigok
Copy link
Member Author

rodrigok commented Oct 3, 2015

@cybercorey we did some improvements in connectivity, can you test again?

@Sing-Li
Copy link
Member

Sing-Li commented Oct 4, 2015

So it seems like we have a problem when one of the browser has the same IP address as the server. When all the rest of the group all have different IP addresses. I'll test that again to make sure.

@Sing-Li
Copy link
Member

Sing-Li commented Oct 4, 2015

Latest code, test results. On LAN:

server IP: 192.168.38.102
client 1 IP: 192.168.38.102
client 2 IP: 192.168.38.110
client 3 IP: 192.168.38.111

client 1 uses http://localhost:3000/ to access sever
client 2 and client 3 uses http://192.168.38.102:3000/ to access server

client 1 gets "START" button in general, sees own video
client 2 gets "START" button in general (not "JOIN") ... sees own video... see very intermitten 'connecting' from client 1
client 3 gets "START" button in general (not "JOIN") ... sees own video ... sees nothing else

Retrying sometimes get "Group Join Room" popup on client 2 - NEVER on client 1.

No error on Client 1 console.
On Client 2 and Client 3 console - see this (almost exact on both):

(server is started via standard 'meteor' dev command ...note the avatar load failure ...trying to do localhost load on client 2 and client 3 .... do we need to set ROOT_URL on dev config? would it matter for webrtc sessions?)

screenerr

@rodrigok
Copy link
Member Author

rodrigok commented Oct 5, 2015

@Sing-Li why all clients gets "START" and not only client 1?

@graywolf336
Copy link
Contributor

How does the screen sharing work?

@mckuchta
Copy link

I think there should be a HTML5 notification when there call invite. Is this a planned feature.

@mckuchta
Copy link

It would be nice to have global controls of the current group call, with a link to the room it is being hosted.

@ma-karai
Copy link

It would be nice to have something similar to "push to talk" and "voice activation" instead of continuous transmission

@brylie
Copy link
Contributor

brylie commented Mar 8, 2016

I am having troubles with stuttering audio and video freezing. Is it possible to adjust the call 'quality', e.g. for lower bandwidth or CPU devices? Another strategy might be to use web workers for audio/video encoding.

@sagar-srivastava
Copy link

does anyone have an idea why my audio and video chat buttons are not clickable at all. I tried both windows client and chrome browser on windows 8.1. my server is a newly setup server on docker

@brylie
Copy link
Contributor

brylie commented Mar 29, 2016

@sagar-srivastava consider opening a new issue that is specific to your question.

@Sing-Li
Copy link
Member

Sing-Li commented Jun 9, 2016

New solution testing this week.

On https://demo.rocket.chat

When you are in a Direct Message or Private Group. You will notice a new video button on the toolbar , just click it anytime to start a video conference with all those in the room

@hughlroberts
Copy link

There's quite a few bugs in this system and really need some improvements made in the system. I've been locked out of my entire session and had to remove the server to get the screen to go away. Quite a few bugs in this system.
screen shot 2016-12-07 at 4 49 16 pm

@armand1m
Copy link
Contributor

armand1m commented Dec 5, 2017

Is there anyone working on this?

@rodrigok
Copy link
Member Author

rodrigok commented Dec 5, 2017

@armand1m currently no, be we are looking for some help here or find some one to focus in webrtc.

@pokapow
Copy link

pokapow commented Dec 25, 2017

I would like to help you to improve webRTC debugging tools, and using improvement in rocket.chat ?
How can I get start to help you ?

@real19
Copy link

real19 commented Sep 8, 2018

So I would like to implement similar functionality of group calling. on the iOS mobile app. Any ideas where to start?

@devopsec
Copy link

devopsec commented Apr 7, 2019

What deliverable's are still needed for this?

@Sing-Li
Copy link
Member

Sing-Li commented Jul 4, 2019

WebRTC features are already part of our core. That will be the limit of our support/implementation.

@Sing-Li Sing-Li closed this as completed Jul 4, 2019
Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this issue Sep 30, 2021
Chore: update livechat in package-lock to bfc00c6f71e4cee78ab0c6f68b0d61cecf65eaec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests