Fix snap install. Remove execstack from sharp, and bypass grpc error #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arm compiles and gets through store, but doesn't start... So we should figure that out. For now I've manually pushed and it's all sorted. So no pressure on this PR |
Closed
|
@rodrigok we need to make sure this one gets in so snap builds will be automatically built again |
|
@RocketChat/core can I get someone to review this. Snaps will not auto build until this is in.. |
graywolf336
approved these changes
Mar 28, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9992
Sharp introduced with 0.62.0 for image processing is compiled with execstack. It had to be removed to play nice with snap strict confinement. More details here: https://forum.snapcraft.io/t/snap-and-executable-stacks/1812
Grpc used by google vision package keeps giving errors. So to bypass it basically copying a file to make it appear where its expected.