Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Accept quoted slash command arguments #11744

Merged
merged 19 commits into from
Jun 22, 2022
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c1a1c29
Changed the apps api to recognize quotes on slash command arguments
pierre-lehnen-rc Aug 10, 2018
3771922
Accept slashed quotes as quotes on slash commands
pierre-lehnen-rc Aug 14, 2018
537153f
Merge branch 'develop' into apps.recognize-quoted-arguments
Hudell Aug 20, 2018
e31523a
new eslint rules
pierre-lehnen-rc Aug 21, 2018
e5eaee5
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Aug 27, 2018
ef5c926
Fixed parameter parsing without quotes
pierre-lehnen-rc Aug 27, 2018
fd89d97
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Sep 10, 2018
343c817
Added support for multiple lines on slash commands
pierre-lehnen-rc Sep 12, 2018
ea3cf49
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Sep 12, 2018
a6dd039
Merge branch 'develop' into apps.recognize-quoted-arguments
Hudell Dec 17, 2018
2d486a3
Merge branch 'develop' into apps.recognize-quoted-arguments
d-gubert Dec 18, 2018
22de99a
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Jun 30, 2020
1075abf
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Jul 16, 2020
37a5b1d
Merge branch 'develop' into apps.recognize-quoted-arguments
sampaiodiego Aug 7, 2020
c75c3f9
Merge branch 'develop' into apps.recognize-quoted-arguments
pierre-lehnen-rc Jun 15, 2022
d914e5a
- Added unit tests
pierre-lehnen-rc Jun 15, 2022
c5543d1
Removed a comment
pierre-lehnen-rc Jun 15, 2022
9f4b7f9
Improved handling of line breaks and tabs
pierre-lehnen-rc Jun 16, 2022
1ffe613
Update apps/meteor/lib/utils/parseParameters.ts
pierre-lehnen-rc Jun 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update apps/meteor/lib/utils/parseParameters.ts
  • Loading branch information
pierre-lehnen-rc authored Jun 17, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 1ffe613a0b52129ca94c1f55680663cdcc4cf8bf
2 changes: 1 addition & 1 deletion apps/meteor/lib/utils/parseParameters.ts
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ export function parseParameters(parameters: string, ignoreExtraUnquotedSpaces =
});

// If two quoted parameters are not separated by a space, add one automatically
line = line.replace(/\u0087\u0086/g, ' ');
line = line.replace(/\u0087\u0086/g, '\u0087 \u0086');

const items = split(line, ignoreExtraUnquotedSpaces);