-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Federation #12370
[NEW] Federation #12370
Conversation
022d830
to
709db1c
Compare
709db1c
to
de1a7e9
Compare
…the way roomss are filtered, and the way to/from usernames are handled
…t rooms, new evvents organization, new callback management, editing messages, deleting messages, better internal search code on directory, read confirmations
…ct rooms, it does not
} catch (error) { | ||
nameValidation = new RegExp('^[0-9a-zA-Z-_.]+$'); | ||
|
||
if (options.nameValidationRegex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if nameValidation = new RegExp(options.nameValidationRegex); throws an error?
my suggestion:
try {
nameValidation = new RegExp(`^${ options.nameValidationRegex || settings.get('UTF8_Names_Validation') }$`)
} catch (error) {
nameValidation = new RegExp('^[0-9a-zA-Z-_.]+$');
}
}
When will the hub software be available? I would like to run the hub software separate from the official one. Thanks! |
I’m not sure what the plans are there. Curious though why you want to run your own hub? |
@geekgonecrazy i would like to allow certain aspects of my community to be pulled out and put under their own administration. I would like to have like foo.mycommunity.net and bar.mycommunity.net to share accounts (so people wouldn't have to create separate accounts) and be able to easily communicate. This is possible with the iframe API, having a callback to the "master" instance, but it isn't as streamlined as I would like it to be. Having the federation system would allow this to work a lot better. |
Interesting. If it’s just about user accounts can do a central authentication source like oauth. Could actually setup one as oauth server. Just to be clear. Federation is letting users on foo.mycommunity.com to talk to users on bar.mycommunity.com Users from foo.mycommunity.com won’t actually be able to login to bar.mycommunity.com. They would stay on their own server and simply join rooms/talk to people on the other server. |
@geekgonecrazy This is something I would find useful as well. As we have multiple locations with separate RC instances, this would allow these locations to be connected together without going through the public federation. We don't need shared accounts, just to be able to comunnicate across the instances. |
@geekgonecrazy yeah it would just allow people to have the ability to communicate between instances without creating a new account and having to have 2 browser tabs open. |
This is an early implementation of Rocket.Chat's federation feature.
This adds a new layer of events that handles the communication between two or more peers.