[FIX] Regression on embedded layout after PR #13471 #13526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @moustachu thanks for your contribution. Your solution ends adding the performance issue back, since it was not clear for me how to help you I ended doing the fix by myself. Can you test it here #13574 ? Thanks again. |
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] Regression on embedded layout after PR #13471
After the optimization on #13471, embedded layout didn't work anymore with the usual
?layout=embeddedquery params.Unfortunately, I don't know the impact on room loading but it could be troublesome for people integrating Rocket in their website.
The revert is pretty simple so I could also propose a hot fix for the
masterbranch if needed.first PR on Rocket, I hope I didn't missed anything 😬