[FIX] Directory and Apps logs page #13938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems apps are using |
|
@sampaiodiego Awkward style reuse... Thanks for warning me. |
|
@tassoevan How css gets broken up here ! In my local environment I am could fix it by using 100% height to input field but it doesn't fix on @sampaiodiego . |
sampaiodiego
requested changes
Mar 29, 2019
| class="rc-input__element js-search" | ||
| name="message-search" | ||
| id="message-search" | ||
| placeholder="{{_ "Search_Apps"}}" |
There was a problem hiding this comment.
Search_Apps is missing from i18n files
sampaiodiego
previously approved these changes
Mar 29, 2019
|
@tassoevan can you fix the margins of the app's logs in this PR? |
sampaiodiego
approved these changes
Apr 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13909