Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] "Discussion" label in Sidebar not hidden, when Discussions are disabled (#14660) #14682

Merged
merged 2 commits into from
Aug 20, 2019
Merged

[FIX] "Discussion" label in Sidebar not hidden, when Discussions are disabled (#14660) #14682

merged 2 commits into from
Aug 20, 2019

Conversation

ifantom
Copy link
Contributor

@ifantom ifantom commented May 29, 2019

Closes #14660

@CLAassistant
Copy link

CLAassistant commented May 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego requested a review from ggazzo May 30, 2019 11:43
@sampaiodiego sampaiodiego added this to the 1.2.0 milestone May 30, 2019
@engelgabriel engelgabriel modified the milestones: 1.2.0, 1.3.0 Jul 10, 2019
@ggazzo ggazzo modified the milestones: 1.3.0, 1.4.0 Jul 22, 2019
@ggazzo ggazzo added the ui/ux label Jul 22, 2019
@ggazzo ggazzo merged commit 880e38b into RocketChat:develop Aug 20, 2019
@ifantom ifantom deleted the discussion-label-in-sidebar branch September 2, 2019 07:01
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

"Discussion" label in Sidebar not hidden, when Discussions are disabled
5 participants
@ifantom @CLAassistant @ggazzo @engelgabriel @sampaiodiego