Font mirror icons fix #1594
Font mirror icons fix #1594
Conversation
…ns with no mirror property
| src: url('./font/fontello.eot?45674533#iefix') format('embedded-opentype'), | ||
| url('./font/fontello.woff?45674533') format('woff'), | ||
| url('./font/fontello.ttf?45674533') format('truetype'), | ||
| url('./font/fontello.svg?45674533#fontello') format('svg'); |
There was a problem hiding this comment.
You are right, i didn't check that file I simply put it inside the folder. But is it actually needed for the project? I feel it is just to check on the output.
|
We should also fix it in a way that the following is no longger requeired: /* Overridding the icons Unicode to suit RTL languages
* from _octicons.less */
.octicon-chevron-right:before { content: '\f0a4'}
.icon-angle-right:before { content: '\e914'; } |
|
True, but that one if a different font, isn't it? I also found the official list of all characters with mirroring property http://www.unicode.org/Public/UCD/latest/ucd/BidiMirroring.txt |
|
I also didn't include the generated svg file thinking it was not used, and now I see that it is in the project folder under private/images. Should I include that also? |
|
The icon-angle-right is fontello... so we can change and fix it. |
Remove the icons that are not mirrored to regular locations. And moved the icons that need mirroring to mirrored locations. Replaced "octicon-chevron-right" with new set of mirrored icons from fontello
|
The new commit should take care of all that. and for the octicon, I added a new one from fontello that similar to its shape |
|
sorry.. can you review the conflicts so I can finally merge? |
…nto patch-font-mirror. Resolved the conflict
Updating the font file to move "spin4" and "sliders" icons to locations with no mirror property