Allow LDAP user to update local user #2088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a user successfully logged in with a LDAP username that matched an existing local username, the login would fail. Now the login will succeed (with the rationale that the user provided legit LDAP credentials) and the existing user object is updated with ldap = true. Signed-off-by: Colin Ho <colin@colinho.com>
|
I believe this will fix #1912. |
|
It may also fix #1823, because I speculate that what happens is the LDAP auth succeeds with the username, which fires the exception that this commit removes. |
|
Also, this commit addresses the "troubleshooting" issue mentioned on the wiki here: https://github.com/RocketChat/Rocket.Chat/wiki/LDAP-Authentication#i-cannot-login-even-everything-looks-good. |
|
@colinho thank you, your solution is great, but I think that this should be optional and can be enabled by default. Can you add an option to disable this in settings? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user successfully logged in with a LDAP username that matched an existing local username, the login would fail. Now the login will succeed (with the rationale that the user provided legit LDAP credentials) and the existing user object is updated with ldap = true.
Signed-off-by: Colin Ho colin@colinho.com