[IMPROVE] Added a new "All" tab which shows all integrations in Integrations #24109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
previously approved these changes
Jan 25, 2022
dougfabris
approved these changes
Jan 31, 2022
|
Thanks @dougfabris 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Screencast-from-06-01-22-01_01_33-AM-IST.mp4
When we access integrations it goes to
/admin/integrations, we can see that the incoming tab is selected whereas the contents of the table are of both incoming and outgoing webhooks. And it could be seen that re-clicking on the incoming tab replaces the previous contents with only incoming webhooks since it goes to/admin/integrations/webhook-incoming.Proposed changes (including videos or screenshots)
I added an "All" tab which becomes the first thing that an admin sees after he clicks on Integrations which contains both incoming and outgoing web hooks and then he can select any other tab and get the desired result.
Screencast-from-06-01-22-12_28_11-AM-IST.mp4
Issue(s)
Steps to test or reproduce
Further comments