-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Issues on selecting users when importing CSV #24253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on users, channels and messages count
matheusbsilva137
requested review from
pierre-lehnen-rc,
tassoevan and
matheusbsilva137
January 21, 2022 17:07
Does not allow import msg without channel
based on users, channels and messages count
Does not allow import msg without channel
matheusbsilva137
previously approved these changes
Jan 27, 2022
tassoevan
requested changes
Feb 1, 2022
remove u, c, m from respective convert function
tassoevan
approved these changes
Feb 1, 2022
pierre-lehnen-rc
approved these changes
Feb 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
usersCount
,channelsCount
andmessageCount
equals 0, or if messageCount is alonedisabled={usersCount === 0}
on user TabSteps to test or reproduce
For user selection error fix:
Create a ZIP file containing only the CSV file you created in the previous step;
Go to Administration > Import > Import New File, then choose CSV as the Import Type and upload the ZIP file from your computer;
Click on Import. Expected behavior: 3 users should be displayed with all the info given in the CSV file.
Click on Start Importing. Expected behavior: all 3 users should be successfully imported with their corresponding real names (what can be checked in Administration > Users);
Delete the 3 users and repeat this process using a CSV with a single user. No error should be displayed in the whole process.
For disabled 'Start Importing' button:
For removed
disabled={usersCount === 0}
on user Tab:Create a ZIP file containing both CSVs file you created (users.csv and channels.csv) in the previous step;
Go to Administration > Import > Import New File, then choose CSV as the Import Type and upload the ZIP file from your computer;
Click on Import. Expected behavior: 3 users and 4 channels should be displayed with all the info given in the CSV file (in different tabs);
Unselect all users. Expect behavior: the 'users' tab should not be disabled.
Further comments
May fix #23772 issue