Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Append path To Route For Custom Emoji #24379

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

nishant23122000
Copy link
Contributor

Proposed changes (including videos or screenshots)

Till now, only the custom-emoji page is opening when the user clicks on add custom emoji but now when the user clicks on add custom emoji, it should redirect to admin/custom-emoji/new and the dialog box will open.

Issue(s)

Steps to test or reproduce

  1. Go to any message
  2. open Add reaction Component
  3. click on add new custom emoji
  4. It will redirect to a custom emoji page.

Further comments

@dougfabris dougfabris added this to the 5.0.0 milestone Jun 27, 2022
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2022
@kodiakhq kodiakhq bot merged commit 20f4382 into RocketChat:develop Jun 27, 2022
gabriellsh added a commit that referenced this pull request Jun 28, 2022
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants