[FIX] Add the requested setting for BioLength and NickName

[aakash-gitdev]

Added the requested setting for BioLength and NickName also.

Proposed changes (including videos or screenshots)

Issue(s)

Closes #24968

Steps to test or reproduce

Further comments

I want someone to kindly review this PR. Also should I add "i18nLabel" field in the add settings of 'NickName' and 'BioLength'? If yes then any kind of help in finding it's location would be great.

[gabriellsh]

There is a couple of things I'd like to point out.

First, answering your question, yes you should add translations when you add a reference to it in a PR.

The other thing is, you added the settings, but you didn't use them. 😛

So, that was mostly a review so far, but I'd like to comment that we shouldn't add setting for this kind of thing. IMO it adds little value and a lot of complexity for maintenance in the future. Instead of adding a setting, you could just add something like const MAX_BIO_LENGTH = 260;. This way, it's no longer a magic number and we don't need a whole setting for it.

Anyway, thanks for the help!

[aakash-gitdev]

There is a couple of things I'd like to point out.

First, answering your question, yes you should add translations when you add a reference to it in a PR.

The other thing is, you added the settings, but you didn't use them. 😛

So, that was mostly a review so far, but I'd like to comment that we shouldn't add setting for this kind of thing. IMO it adds little value and a lot of complexity for maintenance in the future. Instead of adding a setting, you could just add something like const MAX_BIO_LENGTH = 260;. This way, it's no longer a magic number and we don't need a whole setting for it.

Anyway, thanks for the help!

Thanks for your review I should have thought of making it a const instead of changing settings. It would be much simpler, I will like to change the code according to your suggestions

[gabriellsh]

closed in favor of #25231