Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add new events after user login, logout and change his status #25234

Merged
merged 14 commits into from
May 22, 2022

Conversation

tapiarafael
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Rocket.chat.Apps-engine PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
apps/meteor/app/apps/server/status.js

@tapiarafael tapiarafael changed the title Feat/new user events app [NEW] Add new events after user login, logout and change his status Apr 19, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
apps/meteor/app/apps/server/status.js

@lgtm-com
Copy link

lgtm-com bot commented Apr 19, 2022

This pull request introduces 1 alert when merging fdbd7a9 into e419108 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@github-actions github-actions bot dismissed stale reviews from themself April 25, 2022 14:49

js files removed

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging 9fd3d30 into 463d1ca - view on LGTM.com

new alerts:

  • 1 for Syntax error

@tapiarafael tapiarafael force-pushed the feat/new-user-events-app branch from 9fd3d30 to e67a64a Compare April 25, 2022 15:01
@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging e67a64a into 463d1ca - view on LGTM.com

new alerts:

  • 1 for Syntax error

AllanPazRibeiro
AllanPazRibeiro previously approved these changes May 3, 2022
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-gubert d-gubert changed the base branch from develop to feat/user-events-app May 16, 2022 00:24
Base automatically changed from feat/user-events-app to develop May 20, 2022 17:47
@d-gubert d-gubert marked this pull request as ready for review May 22, 2022 21:41
@d-gubert d-gubert merged commit 75a1b88 into develop May 22, 2022
@d-gubert d-gubert deleted the feat/new-user-events-app branch May 22, 2022 21:41
gabriellsh added a commit that referenced this pull request May 23, 2022
…adMessagePreview

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] Pinned Message display cutting off information (#25535)
  Chore: Dependencies upgrade (#25290)
  Chore: bump fuselage (#25605)
  [NEW] Federation (Alpha Stabilization) (#25457)
  Chore: Convert to typescript some functions from app/lib/server/functions (#24519)
  [NEW] Add option to show mentions badge when show counter is disabled (#25329)
  [FIX] Fixing Network connectivity issues with SIP client. (#25391)
  [FIX] Ordered and unordered list styles, Line breaks. (#25494)
  Chore: Convert slashCommands to typescript (#25592)
  [NEW] Get user's preferred language via apps (#25514)
  [NEW] Star message, report and delete message events (#25383)
  [NEW] Add new events after user login, logout and change his status (#25234)
  [NEW] Add new app events for pin, react and follow message (#25337)
  Chore: Convert AutoTranslate (#25591)
  Chore: Migrate retention-policy to ts (#25582)
  Chore: Convert to typescript the slash commands help files (#24307)
  Chore: Convert Create Channel (#25589)
  Chore: Convert additionalForms (#25586)
  Chore: Rewrite autotranslate to ts (#25425)
  [NEW] Add user events for apps (#25165)
  ...
@wreiske
Copy link
Contributor

wreiske commented May 23, 2022

Yes! Yes! And YES! Thank you for this PR and the other PRs related to user events. You guys rock!!

ggazzo pushed a commit that referenced this pull request May 24, 2022
…25234)

* Add user events for apps

* Add login, logout and status change events

* Remove trycatch validation

* Remove trycatch validation

* Get the user entity after the update

* Change status file to Typescript

* Trigger events when the user updates his profile or deletes his account

* Update Apps-Engine

* Make update return doc after update

* Trigger the event when the user also uses third-party apps to log in

* Revert user update change
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants