-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Convert Admin/OAuthApps to TS #25277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RocketChat/backend I can see some missing endpoints, could you provide them ? thanks ;) |
@yash-rajpal just pay attention, resolving conflicts its not only about accepting all incomings ;) |
ggazzo
force-pushed
the
chore/oauthapps-ts
branch
from
April 28, 2022 13:34
7dfa0e0
to
1e40eba
Compare
ggazzo
previously approved these changes
Apr 28, 2022
ggazzo
force-pushed
the
chore/oauthapps-ts
branch
from
April 28, 2022 13:59
1e40eba
to
3a5b6df
Compare
ggazzo
force-pushed
the
chore/oauthapps-ts
branch
from
April 28, 2022 15:01
3a5b6df
to
e704fe7
Compare
ggazzo
approved these changes
Apr 28, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments