Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert Admin/OAuthApps to TS #25277

Merged
merged 10 commits into from
May 4, 2022
Merged

Chore: Convert Admin/OAuthApps to TS #25277

merged 10 commits into from
May 4, 2022

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Apr 22, 2022

Proposed changes (including videos or screenshots)

  • Converts Admin/OAuthApps to TS.
  • migrated forms to react-hook-form

Issue(s)

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal requested a review from a team April 22, 2022 19:07
@ggazzo ggazzo added the eng day label Apr 22, 2022
@ggazzo ggazzo added the backend label Apr 26, 2022
@ggazzo
Copy link
Member

ggazzo commented Apr 26, 2022

@RocketChat/backend I can see some missing endpoints, could you provide them ? thanks ;)

@yash-rajpal yash-rajpal requested a review from a team as a code owner April 27, 2022 01:06
@ggazzo
Copy link
Member

ggazzo commented Apr 28, 2022

@yash-rajpal just pay attention, resolving conflicts its not only about accepting all incomings ;)

@ggazzo ggazzo force-pushed the chore/oauthapps-ts branch from 7dfa0e0 to 1e40eba Compare April 28, 2022 13:34
ggazzo
ggazzo previously approved these changes Apr 28, 2022
@ggazzo ggazzo force-pushed the chore/oauthapps-ts branch from 3a5b6df to e704fe7 Compare April 28, 2022 15:01
@ggazzo ggazzo merged commit 83de637 into develop May 4, 2022
@ggazzo ggazzo deleted the chore/oauthapps-ts branch May 4, 2022 17:05
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants