Chore: Add channel endpoints (rest-typings) #25279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Apr 26, 2022
| @@ -125,4 +125,14 @@ export type ChannelsEndpoints = { | |||
| messages: IMessage[]; | |||
| }; | |||
| }; | |||
| "channels.addAll": { | |||
| POST: (params: { roomId: string; activeUserOnly?: boolean }) => { | |||
There was a problem hiding this comment.
Suggested change
| POST: (params: { roomId: string; activeUserOnly?: boolean }) => { | |
| POST: (params: ({ roomId: string; } | { roomId?: string; roomName }) & { activeUserOnly?: boolean }) => { |
Comment on lines
134
to
136
| GET: (params: { roomId?: string; roomName?: string }) => { | ||
| messages: IMessage[]; | ||
| }; |
There was a problem hiding this comment.
wrong params and missing results and request props, see PaginatedRequest and PaginatedResult
ggazzo
previously approved these changes
May 9, 2022
ggazzo
force-pushed
the
channel-endpoints
branch
4 times, most recently
from
a41e119 to
3e752b5
Compare
ggazzo
approved these changes
May 9, 2022
gabriellsh
added a commit
that referenced
this pull request
May 12, 2022
…lists * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Move admin sidebarItems registration to the main file (#25442) [FIX] Sanitize customUserStatus and fix infinite loop (#25449) [IMPROVE] Fix multiple bugs with Matrix bridge (#25318) Chore: Convert `UserStatusMenu` to TS (#25265) Chore: Chore add validation option to rest endpoints (#25443) Chore: Add channel endpoints (rest-typings) (#25279) Update Codeowners Chore: Dedicated package for UI contexts (#25432)
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments