Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Endpoint types with Ajv Coercing data types #25644

Merged
merged 3 commits into from
May 27, 2022
Merged

Regression: Endpoint types with Ajv Coercing data types #25644

merged 3 commits into from
May 27, 2022

Conversation

albuquerquefabio
Copy link
Contributor

@albuquerquefabio albuquerquefabio commented May 26, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Ajv Coercing data types should be true to accept all kinds of data requested.

Issue(s)

Request > {{HOST}}/api/v1/channels.history?roomId=abcd123&count=50

// 400 Bad Request
{
    "success": false,
    "error": "must be number [invalid-params]",
    "errorType": "invalid-params"
}

Steps to test or reproduce

Further comments

@albuquerquefabio albuquerquefabio requested a review from a team as a code owner May 26, 2022 15:52
@KevLehman
Copy link
Contributor

Maybe's a good time for this: https://ajv.js.org/guide/modifying-data.html#coercing-data-types

@albuquerquefabio
Copy link
Contributor Author

Maybe's a good time for this: https://ajv.js.org/guide/modifying-data.html#coercing-data-types

Works fine!

@albuquerquefabio albuquerquefabio changed the title [FIX] For GET request props on type should be string [FIX] Endpoint types with Ajv Coercing data types May 26, 2022
@ggazzo ggazzo changed the title [FIX] Endpoint types with Ajv Coercing data types Regression: Endpoint types with Ajv Coercing data types May 27, 2022
@ggazzo
Copy link
Member

ggazzo commented May 27, 2022

what do you think about create some tests using pagination?

@ggazzo ggazzo merged commit 78e57f5 into develop May 27, 2022
@ggazzo ggazzo deleted the fix/endpoint-props branch May 27, 2022 15:54
@d-gubert d-gubert mentioned this pull request May 31, 2022
Merged
albuquerquefabio added a commit that referenced this pull request Jun 2, 2022
@albuquerquefabio
Squashed commit of the following:
0179e1b 
commit 19a996a
Author: Douglas Fabris <devfabris@gmail.com>
Date:   Thu Jun 2 11:58:46 2022 -0300

    [FIX] Unnecessary padding on teams channels footer (#25712)

commit 8274ba3
Author: Hugo Costa <hugocarreiracosta@gmail.com>
Date:   Thu Jun 2 11:00:52 2022 -0300

    [FIX] Messages spacing (#25631)

    * fix(fuselage): adding sequential param to Message Component

    * chore: updating fuselage version

    * fix: updating yarn.lock

    * fix yarn.lock

    * Update fuselage

    * remove dev deps

    Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

commit d24789a
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Wed Jun 1 17:09:34 2022 -0300

    Chore: Custom Sounds Endpoints (#25633)

commit db257d3
Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Date:   Wed Jun 1 22:11:12 2022 +0530

    [FIX] User's with non-agent role shown on voip agent association model (#25682)

commit c8fba6f
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Wed Jun 1 13:37:58 2022 -0300

    Fix CI

commit afbb708
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Wed Jun 1 13:09:17 2022 -0300

    fix CI

commit c5def57
Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Date:   Wed Jun 1 12:27:08 2022 -0300

    Chore: Convert CreateChannelWithData (#25667)

commit bcd4b1b
Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Date:   Wed Jun 1 12:25:58 2022 -0300

    Chore: Convert UserAutoCompleteMultiple (#25587)

    Co-authored-by: julia foresti <juliaforesti@julias-MacBook-Pro.local>

commit 08656e3
Author: amolghode1981 <86001342+amolghode1981@users.noreply.github.com>
Date:   Wed Jun 1 20:55:32 2022 +0530

    Chore: Converting files from app/livechat folder from JS to TS (#25658)

commit c2c1bf4
Author: Jean Brito <jeanfbrito@gmail.com>
Date:   Wed Jun 1 11:36:08 2022 -0300

    Chore: Convert sidebar/header/actions (#25581)

    Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

commit 44d6798
Author: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Date:   Tue May 31 23:00:14 2022 -0300

    Chore: Converting omnichannel installation files to ts (#25665)

commit cd32f09
Author: Jean Brito <jeanfbrito@gmail.com>
Date:   Tue May 31 22:55:02 2022 -0300

    Chore: Convert to TS omnichannel/agent (#25511)

    Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

commit 6b41aa6
Author: Jean Brito <jeanfbrito@gmail.com>
Date:   Tue May 31 22:52:51 2022 -0300

    Chore: Convert components/sidebar to TS (#25429)

    Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

commit 6c1a7b1
Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Date:   Tue May 31 22:52:04 2022 -0300

    Chore: Convert apps/meteor/client/sidebar/header/index (#25671)

commit 5b81dba
Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
Date:   Tue May 31 22:51:27 2022 -0300

    Chore: Migrate some small helper functions to TypeScript (#25666)

commit ad67cd3
Author: Douglas Gubert <douglas.gubert@gmail.com>
Date:   Tue May 31 22:50:13 2022 -0300

    Merge master into develop & Set version to 5.0.0 (#25702)

commit 80fc5b7
Author: Douglas Gubert <douglas.gubert@gmail.com>
Date:   Tue May 31 17:05:29 2022 -0300

    Chore: Update Apps-Engine and Fuselage (#25700)

commit 88a8e8e
Author: Douglas Gubert <douglas.gubert@gmail.com>
Date:   Tue May 31 11:06:52 2022 -0300

    Regression: App event listeners broke Slackbridge integration and importers (#25689)

commit bf3483d
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Mon May 30 23:44:01 2022 -0300

    [FIX] Fix max-width message block (#25686)

commit b1d855e
Author: Sinyoung "Divinespear" Kang <divinespear@gmail.com>
Date:   Tue May 31 10:27:14 2022 +0900

    [FIX] Change form body parameter charset to UTF-8 to fix issue #25456 (#25673)

commit 51845b1
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Mon May 30 22:26:55 2022 -0300

    Regression: Fix sort field files.list (#25687)

    Co-authored-by: Fábio Albuquerque <albuquerquefabio@icloud.com>

commit 713120e
Author: Carlos Rodrigues <carlos.1994hrs@gmail.com>
Date:   Mon May 30 17:59:57 2022 -0300

    fix git conflict (#25684)

commit 62405c6
Author: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Date:   Mon May 30 12:47:44 2022 -0300

    [FIX] Prevent federation crash on invite users as a non-owner user (#25683)

    * fix: prevent crashing when inviting someone as non-owner

    * chore: fix lint

commit d364be4
Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
Date:   Mon May 30 11:21:16 2022 -0300

    Regression: Broken components on Federation and Engagement dashboards (#25653)

    * Fix odd typechecking issues with JSON modules

    * Avoid `data` as directory for modules

    * rename other `data` folder

    Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

commit 4894fc2
Author: Douglas Fabris <devfabris@gmail.com>
Date:   Fri May 27 16:23:07 2022 -0300

    Regression: Update settings groups description (#25663)

commit 5a0d29f
Author: Hugo Costa <hugocarreiracosta@gmail.com>
Date:   Fri May 27 13:45:51 2022 -0300

    [FIX] Click to join button Jitsi Call (#25569)

    * fix: Click to join button Jitsi Call

    * Fix `yarn` references

    * fix: Old message Jitsi Button

    * Fix yarn references (again)

    * Update apps/meteor/app/action-links/client/lib/actionLinks.ts

    Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

    * fix: changing instance type

    Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

commit 78e57f5
Author: Fábio Albuquerque <albuquerquefabio@icloud.com>
Date:   Fri May 27 12:54:04 2022 -0300

    Regression: Endpoint types with Ajv Coercing data types (#25644)

commit 7dd89fc
Author: Kevin Aleman <kaleman960@gmail.com>
Date:   Fri May 27 02:20:57 2022 -0600

    Regression: Change logic to check if connection is online on unstable networks (#25618)

    * Change .race for .allsettled so rejections are handled better

    * improve to unstable check logic

    * CR suggestions

commit 195f90a
Author: Douglas Fabris <devfabris@gmail.com>
Date:   Thu May 26 23:37:56 2022 -0300

    Regression: Missing settings group descriptions (#25639)

commit 31ae30f
Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
Date:   Thu May 26 19:11:41 2022 -0300

    Chore: Rest API query parameters handling (#25648)

commit 052858d
Author: Aleksander Nicacio da Silva <aleksander.nsilva@gmail.com>
Date:   Thu May 26 18:36:07 2022 -0300

    Regression: VoIp wrap up modal not opening after call disconnect (#25651)

commit 3cd0cab
Author: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
Date:   Thu May 26 15:39:15 2022 -0300

    [FIX] Remove 'total' text in admin info page (#25638)

    * fix: rm intial 'total' from rooms & total groups

    * fix: change key of 'total messages' title

    * feat: cr8 'total_rooms'='Total Rooms' in en.i18n

    replace it from 'rooms' title in rooms group

    * fix: change pt-BR.i18n to remove initial 'total'

commit 6f3133f
Author: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Date:   Thu May 26 13:28:48 2022 -0300

    Chore: Increase performance and security of integrations’ scripts (#25641)

commit cbb0844
Author: Hugo Costa <hugocarreiracosta@gmail.com>
Date:   Thu May 26 12:12:32 2022 -0300

    [FIX] Quote message spacing (#25613)

    * fix: default margins for outer quote

    * fix: Removing condition to style differently the inner quote

    * fix: updating yarn.lock

commit 2452448
Author: Douglas Fabris <devfabris@gmail.com>
Date:   Wed May 25 15:10:07 2022 -0300

    Regression: Assets & Slack Bridge Setting Page not rendering (#25629)

    * fix: RoomPickSettingInput

    * fix: assets page broken

commit ca4c020
Author: Henrique Guimarães Ribeiro <henrique.jobs1@gmail.com>
Date:   Tue May 24 22:39:11 2022 -0300

    Regression: Subscription menu not appearing for non installed but subscribed apps (#25627)

    * fix: 🐛 Fix subscribe menu option not appearing

    Fixed a problem on which the AppMenu component did not appear for apps that had an active subscription but weren't installed, now the rendering of the component is also based on the isSubscribed flag, and the appearance of the uninstall and enable/disable options are based on the app.installed flag.

    * fix: 🐛 Fix AppMenu overflow error on Marketplace/AppRow

    Fixed a visual error on which the AppMenu component would overflow the right side of its container and have part of itself hidden.

    * fix: 🐛 FIx isSubscribed wrongful typing

    Fixed an oversight where I've typed isSubscribed as string instead of boolean
albuquerquefabio added a commit that referenced this pull request Jun 2, 2022
@albuquerquefabio
Squashed commit of the following:
aad0b70 
commit 0179e1b
Author: albuquerquefabio <albuquerquefabio@icloud.com>
Date:   Thu Jun 2 13:32:52 2022 -0300

    Squashed commit of the following:

    commit 19a996a
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Thu Jun 2 11:58:46 2022 -0300

        [FIX] Unnecessary padding on teams channels footer (#25712)

    commit 8274ba3
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Thu Jun 2 11:00:52 2022 -0300

        [FIX] Messages spacing (#25631)

        * fix(fuselage): adding sequential param to Message Component

        * chore: updating fuselage version

        * fix: updating yarn.lock

        * fix yarn.lock

        * Update fuselage

        * remove dev deps

        Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

    commit d24789a
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 17:09:34 2022 -0300

        Chore: Custom Sounds Endpoints (#25633)

    commit db257d3
    Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
    Date:   Wed Jun 1 22:11:12 2022 +0530

        [FIX] User's with non-agent role shown on voip agent association model (#25682)

    commit c8fba6f
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 13:37:58 2022 -0300

        Fix CI

    commit afbb708
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 13:09:17 2022 -0300

        fix CI

    commit c5def57
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Wed Jun 1 12:27:08 2022 -0300

        Chore: Convert CreateChannelWithData (#25667)

    commit bcd4b1b
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Wed Jun 1 12:25:58 2022 -0300

        Chore: Convert UserAutoCompleteMultiple (#25587)

        Co-authored-by: julia foresti <juliaforesti@julias-MacBook-Pro.local>

    commit 08656e3
    Author: amolghode1981 <86001342+amolghode1981@users.noreply.github.com>
    Date:   Wed Jun 1 20:55:32 2022 +0530

        Chore: Converting files from app/livechat folder from JS to TS (#25658)

    commit c2c1bf4
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Wed Jun 1 11:36:08 2022 -0300

        Chore: Convert sidebar/header/actions (#25581)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 44d6798
    Author: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
    Date:   Tue May 31 23:00:14 2022 -0300

        Chore: Converting omnichannel installation files to ts (#25665)

    commit cd32f09
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Tue May 31 22:55:02 2022 -0300

        Chore: Convert to TS omnichannel/agent (#25511)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 6b41aa6
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Tue May 31 22:52:51 2022 -0300

        Chore: Convert components/sidebar to TS (#25429)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 6c1a7b1
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Tue May 31 22:52:04 2022 -0300

        Chore: Convert apps/meteor/client/sidebar/header/index (#25671)

    commit 5b81dba
    Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
    Date:   Tue May 31 22:51:27 2022 -0300

        Chore: Migrate some small helper functions to TypeScript (#25666)

    commit ad67cd3
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 22:50:13 2022 -0300

        Merge master into develop & Set version to 5.0.0 (#25702)

    commit 80fc5b7
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 17:05:29 2022 -0300

        Chore: Update Apps-Engine and Fuselage (#25700)

    commit 88a8e8e
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 11:06:52 2022 -0300

        Regression: App event listeners broke Slackbridge integration and importers (#25689)

    commit bf3483d
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Mon May 30 23:44:01 2022 -0300

        [FIX] Fix max-width message block (#25686)

    commit b1d855e
    Author: Sinyoung "Divinespear" Kang <divinespear@gmail.com>
    Date:   Tue May 31 10:27:14 2022 +0900

        [FIX] Change form body parameter charset to UTF-8 to fix issue #25456 (#25673)

    commit 51845b1
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Mon May 30 22:26:55 2022 -0300

        Regression: Fix sort field files.list (#25687)

        Co-authored-by: Fábio Albuquerque <albuquerquefabio@icloud.com>

    commit 713120e
    Author: Carlos Rodrigues <carlos.1994hrs@gmail.com>
    Date:   Mon May 30 17:59:57 2022 -0300

        fix git conflict (#25684)

    commit 62405c6
    Author: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
    Date:   Mon May 30 12:47:44 2022 -0300

        [FIX] Prevent federation crash on invite users as a non-owner user (#25683)

        * fix: prevent crashing when inviting someone as non-owner

        * chore: fix lint

    commit d364be4
    Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
    Date:   Mon May 30 11:21:16 2022 -0300

        Regression: Broken components on Federation and Engagement dashboards (#25653)

        * Fix odd typechecking issues with JSON modules

        * Avoid `data` as directory for modules

        * rename other `data` folder

        Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

    commit 4894fc2
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Fri May 27 16:23:07 2022 -0300

        Regression: Update settings groups description (#25663)

    commit 5a0d29f
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Fri May 27 13:45:51 2022 -0300

        [FIX] Click to join button Jitsi Call (#25569)

        * fix: Click to join button Jitsi Call

        * Fix `yarn` references

        * fix: Old message Jitsi Button

        * Fix yarn references (again)

        * Update apps/meteor/app/action-links/client/lib/actionLinks.ts

        Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

        * fix: changing instance type

        Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

    commit 78e57f5
    Author: Fábio Albuquerque <albuquerquefabio@icloud.com>
    Date:   Fri May 27 12:54:04 2022 -0300

        Regression: Endpoint types with Ajv Coercing data types (#25644)

    commit 7dd89fc
    Author: Kevin Aleman <kaleman960@gmail.com>
    Date:   Fri May 27 02:20:57 2022 -0600

        Regression: Change logic to check if connection is online on unstable networks (#25618)

        * Change .race for .allsettled so rejections are handled better

        * improve to unstable check logic

        * CR suggestions

    commit 195f90a
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Thu May 26 23:37:56 2022 -0300

        Regression: Missing settings group descriptions (#25639)

    commit 31ae30f
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Thu May 26 19:11:41 2022 -0300

        Chore: Rest API query parameters handling (#25648)

    commit 052858d
    Author: Aleksander Nicacio da Silva <aleksander.nsilva@gmail.com>
    Date:   Thu May 26 18:36:07 2022 -0300

        Regression: VoIp wrap up modal not opening after call disconnect (#25651)

    commit 3cd0cab
    Author: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
    Date:   Thu May 26 15:39:15 2022 -0300

        [FIX] Remove 'total' text in admin info page (#25638)

        * fix: rm intial 'total' from rooms & total groups

        * fix: change key of 'total messages' title

        * feat: cr8 'total_rooms'='Total Rooms' in en.i18n

        replace it from 'rooms' title in rooms group

        * fix: change pt-BR.i18n to remove initial 'total'

    commit 6f3133f
    Author: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
    Date:   Thu May 26 13:28:48 2022 -0300

        Chore: Increase performance and security of integrations’ scripts (#25641)

    commit cbb0844
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Thu May 26 12:12:32 2022 -0300

        [FIX] Quote message spacing (#25613)

        * fix: default margins for outer quote

        * fix: Removing condition to style differently the inner quote

        * fix: updating yarn.lock

    commit 2452448
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Wed May 25 15:10:07 2022 -0300

        Regression: Assets & Slack Bridge Setting Page not rendering (#25629)

        * fix: RoomPickSettingInput

        * fix: assets page broken

    commit ca4c020
    Author: Henrique Guimarães Ribeiro <henrique.jobs1@gmail.com>
    Date:   Tue May 24 22:39:11 2022 -0300

        Regression: Subscription menu not appearing for non installed but subscribed apps (#25627)

        * fix: 🐛 Fix subscribe menu option not appearing

        Fixed a problem on which the AppMenu component did not appear for apps that had an active subscription but weren't installed, now the rendering of the component is also based on the isSubscribed flag, and the appearance of the uninstall and enable/disable options are based on the app.installed flag.

        * fix: 🐛 Fix AppMenu overflow error on Marketplace/AppRow

        Fixed a visual error on which the AppMenu component would overflow the right side of its container and have part of itself hidden.

        * fix: 🐛 FIx isSubscribed wrongful typing

        Fixed an oversight where I've typed isSubscribed as string instead of boolean
albuquerquefabio added a commit that referenced this pull request Jun 2, 2022
@albuquerquefabio
Squashed commit of the following:
8199624 
commit 0179e1b
Author: albuquerquefabio <albuquerquefabio@icloud.com>
Date:   Thu Jun 2 13:32:52 2022 -0300

    Squashed commit of the following:

    commit 19a996a
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Thu Jun 2 11:58:46 2022 -0300

        [FIX] Unnecessary padding on teams channels footer (#25712)

    commit 8274ba3
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Thu Jun 2 11:00:52 2022 -0300

        [FIX] Messages spacing (#25631)

        * fix(fuselage): adding sequential param to Message Component

        * chore: updating fuselage version

        * fix: updating yarn.lock

        * fix yarn.lock

        * Update fuselage

        * remove dev deps

        Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

    commit d24789a
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 17:09:34 2022 -0300

        Chore: Custom Sounds Endpoints (#25633)

    commit db257d3
    Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
    Date:   Wed Jun 1 22:11:12 2022 +0530

        [FIX] User's with non-agent role shown on voip agent association model (#25682)

    commit c8fba6f
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 13:37:58 2022 -0300

        Fix CI

    commit afbb708
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Wed Jun 1 13:09:17 2022 -0300

        fix CI

    commit c5def57
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Wed Jun 1 12:27:08 2022 -0300

        Chore: Convert CreateChannelWithData (#25667)

    commit bcd4b1b
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Wed Jun 1 12:25:58 2022 -0300

        Chore: Convert UserAutoCompleteMultiple (#25587)

        Co-authored-by: julia foresti <juliaforesti@julias-MacBook-Pro.local>

    commit 08656e3
    Author: amolghode1981 <86001342+amolghode1981@users.noreply.github.com>
    Date:   Wed Jun 1 20:55:32 2022 +0530

        Chore: Converting files from app/livechat folder from JS to TS (#25658)

    commit c2c1bf4
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Wed Jun 1 11:36:08 2022 -0300

        Chore: Convert sidebar/header/actions (#25581)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 44d6798
    Author: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
    Date:   Tue May 31 23:00:14 2022 -0300

        Chore: Converting omnichannel installation files to ts (#25665)

    commit cd32f09
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Tue May 31 22:55:02 2022 -0300

        Chore: Convert to TS omnichannel/agent (#25511)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 6b41aa6
    Author: Jean Brito <jeanfbrito@gmail.com>
    Date:   Tue May 31 22:52:51 2022 -0300

        Chore: Convert components/sidebar to TS (#25429)

        Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

    commit 6c1a7b1
    Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
    Date:   Tue May 31 22:52:04 2022 -0300

        Chore: Convert apps/meteor/client/sidebar/header/index (#25671)

    commit 5b81dba
    Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
    Date:   Tue May 31 22:51:27 2022 -0300

        Chore: Migrate some small helper functions to TypeScript (#25666)

    commit ad67cd3
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 22:50:13 2022 -0300

        Merge master into develop & Set version to 5.0.0 (#25702)

    commit 80fc5b7
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 17:05:29 2022 -0300

        Chore: Update Apps-Engine and Fuselage (#25700)

    commit 88a8e8e
    Author: Douglas Gubert <douglas.gubert@gmail.com>
    Date:   Tue May 31 11:06:52 2022 -0300

        Regression: App event listeners broke Slackbridge integration and importers (#25689)

    commit bf3483d
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Mon May 30 23:44:01 2022 -0300

        [FIX] Fix max-width message block (#25686)

    commit b1d855e
    Author: Sinyoung "Divinespear" Kang <divinespear@gmail.com>
    Date:   Tue May 31 10:27:14 2022 +0900

        [FIX] Change form body parameter charset to UTF-8 to fix issue #25456 (#25673)

    commit 51845b1
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Mon May 30 22:26:55 2022 -0300

        Regression: Fix sort field files.list (#25687)

        Co-authored-by: Fábio Albuquerque <albuquerquefabio@icloud.com>

    commit 713120e
    Author: Carlos Rodrigues <carlos.1994hrs@gmail.com>
    Date:   Mon May 30 17:59:57 2022 -0300

        fix git conflict (#25684)

    commit 62405c6
    Author: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
    Date:   Mon May 30 12:47:44 2022 -0300

        [FIX] Prevent federation crash on invite users as a non-owner user (#25683)

        * fix: prevent crashing when inviting someone as non-owner

        * chore: fix lint

    commit d364be4
    Author: Tasso Evangelista <tasso.evangelista@rocket.chat>
    Date:   Mon May 30 11:21:16 2022 -0300

        Regression: Broken components on Federation and Engagement dashboards (#25653)

        * Fix odd typechecking issues with JSON modules

        * Avoid `data` as directory for modules

        * rename other `data` folder

        Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>

    commit 4894fc2
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Fri May 27 16:23:07 2022 -0300

        Regression: Update settings groups description (#25663)

    commit 5a0d29f
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Fri May 27 13:45:51 2022 -0300

        [FIX] Click to join button Jitsi Call (#25569)

        * fix: Click to join button Jitsi Call

        * Fix `yarn` references

        * fix: Old message Jitsi Button

        * Fix yarn references (again)

        * Update apps/meteor/app/action-links/client/lib/actionLinks.ts

        Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

        * fix: changing instance type

        Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

    commit 78e57f5
    Author: Fábio Albuquerque <albuquerquefabio@icloud.com>
    Date:   Fri May 27 12:54:04 2022 -0300

        Regression: Endpoint types with Ajv Coercing data types (#25644)

    commit 7dd89fc
    Author: Kevin Aleman <kaleman960@gmail.com>
    Date:   Fri May 27 02:20:57 2022 -0600

        Regression: Change logic to check if connection is online on unstable networks (#25618)

        * Change .race for .allsettled so rejections are handled better

        * improve to unstable check logic

        * CR suggestions

    commit 195f90a
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Thu May 26 23:37:56 2022 -0300

        Regression: Missing settings group descriptions (#25639)

    commit 31ae30f
    Author: Guilherme Gazzo <guilhermegazzo@gmail.com>
    Date:   Thu May 26 19:11:41 2022 -0300

        Chore: Rest API query parameters handling (#25648)

    commit 052858d
    Author: Aleksander Nicacio da Silva <aleksander.nsilva@gmail.com>
    Date:   Thu May 26 18:36:07 2022 -0300

        Regression: VoIp wrap up modal not opening after call disconnect (#25651)

    commit 3cd0cab
    Author: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com>
    Date:   Thu May 26 15:39:15 2022 -0300

        [FIX] Remove 'total' text in admin info page (#25638)

        * fix: rm intial 'total' from rooms & total groups

        * fix: change key of 'total messages' title

        * feat: cr8 'total_rooms'='Total Rooms' in en.i18n

        replace it from 'rooms' title in rooms group

        * fix: change pt-BR.i18n to remove initial 'total'

    commit 6f3133f
    Author: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
    Date:   Thu May 26 13:28:48 2022 -0300

        Chore: Increase performance and security of integrations’ scripts (#25641)

    commit cbb0844
    Author: Hugo Costa <hugocarreiracosta@gmail.com>
    Date:   Thu May 26 12:12:32 2022 -0300

        [FIX] Quote message spacing (#25613)

        * fix: default margins for outer quote

        * fix: Removing condition to style differently the inner quote

        * fix: updating yarn.lock

    commit 2452448
    Author: Douglas Fabris <devfabris@gmail.com>
    Date:   Wed May 25 15:10:07 2022 -0300

        Regression: Assets & Slack Bridge Setting Page not rendering (#25629)

        * fix: RoomPickSettingInput

        * fix: assets page broken

    commit ca4c020
    Author: Henrique Guimarães Ribeiro <henrique.jobs1@gmail.com>
    Date:   Tue May 24 22:39:11 2022 -0300

        Regression: Subscription menu not appearing for non installed but subscribed apps (#25627)

        * fix: 🐛 Fix subscribe menu option not appearing

        Fixed a problem on which the AppMenu component did not appear for apps that had an active subscription but weren't installed, now the rendering of the component is also based on the isSubscribed flag, and the appearance of the uninstall and enable/disable options are based on the app.installed flag.

        * fix: 🐛 Fix AppMenu overflow error on Marketplace/AppRow

        Fixed a visual error on which the AppMenu component would overflow the right side of its container and have part of itself hidden.

        * fix: 🐛 FIx isSubscribed wrongful typing

        Fixed an oversight where I've typed isSubscribed as string instead of boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albuquerquefabio @KevLehman @ggazzo