[FIX] Fix prom-client new promise usage #25781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
changed the title
geekgonecrazy
approved these changes
Jun 8, 2022
ggazzo
approved these changes
Jun 8, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
… feat/custom-homepage-setting * 'new/homepage' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
ggazzo
pushed a commit
that referenced
this pull request
Jun 9, 2022
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> ## Proposed changes (including videos or screenshots) <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> ## Issue(s) <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> ## Steps to test or reproduce <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> ## Further comments <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Looks like the update of de dep had breaking changes and now uses promises at some calls. This PR fixes those promise usages and converts the file to TS (hopefully it helps us to spot the error in the future)
Merged
gabriellsh
added a commit
that referenced
this pull request
Jun 9, 2022
… feat/new-header * 'new/homepage' of github.com:RocketChat/Rocket.Chat: [NEW] Add Custom homepage Content Setting (#25777) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 10, 2022
…e/split-useUserInfoActions * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) [FIX] Wrong argument name preventing Omnichannel Chat Forward to User (#25723) [FIX] AccountBox checks for condition (#25708) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Looks like the update of de dep had breaking changes and now uses promises at some calls. This PR fixes those promise usages and converts the file to TS (hopefully it helps us to spot the error in the future)