-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Users without the view-other-user-info
permission can't use the users.list
endpoint
#26050
Conversation
now this is a break change |
users.list
users.list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better approach would be to update the defaultQuery
in getNonEmptyQuery
so that the emails.address
field is included only for users with the view-full-other-user-info
.
Also, we should add type
to the defaultFields
in the getNonEmptyFields
function in order to support searches by type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pr description is saying users need the view-user-administration
permission, not seeing the check there (in the route options you can add permissionsRequired: ['view-user-administration']
.
@debdutdeb my bad, I forgot to update the description but this permission is not needed anymore, looks like the endpoint is going to be available for all users. @matheusbsilva137 can confirm. |
users.list
users.list
users.list
view-other-user-info
permission are unable to use users.list
view-other-user-info
permission are unable to use users.list
view-other-user-info
permission are unable to use users.list
view-other-user-info
permission are unable to use users.list
view-other-user-info
permission can't use the users.list
endpoint
It's working fine. |
Proposed changes (including videos or screenshots)
This PR fix the query when a normal users access
users.list
Issue(s)
Closes: #25728
Steps to test or reproduce
Further comments