Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: UIKit buttons auth user validation #26171

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

tapiarafael
Copy link
Member

Proposed changes (including videos or screenshots)

Fix the validation to match the new feature that allows apps to register auth-required routes.

Issue(s)

Steps to test or reproduce

Further comments

@tapiarafael tapiarafael requested a review from a team as a code owner July 7, 2022 13:19
@tapiarafael tapiarafael changed the title [FIX] UiKit buttons auth user validation [FIX] UIKit buttons auth user validation Jul 7, 2022
AllanPazRibeiro
AllanPazRibeiro previously approved these changes Jul 7, 2022
@d-gubert d-gubert changed the title [FIX] UIKit buttons auth user validation Regression: UIKit buttons auth user validation Jul 7, 2022
@d-gubert d-gubert added this to the 5.0.0 milestone Jul 7, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 7, 2022
@ggazzo ggazzo merged commit 9667ee0 into develop Jul 11, 2022
@ggazzo ggazzo deleted the fix/block-action-auth-user branch July 11, 2022 18:51
gabriellsh added a commit that referenced this pull request Jul 12, 2022
…jumpMessage

* 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits)
  Chore: Remove unused migrations (#26102)
  Regression: Fix files list endpoints (#26226)
  Regression: Fix Omnichannel not working after meteor update (#26194)
  Regression: Empty URL previews in messages. (#26160)
  Regression: OTR with new React Messages (#26179)
  Regression: Replace contact center icon (#26216)
  Regression: Fix rendered markdown styling on app info page details section (#26093)
  [BREAK] Remove webRTC for channels/dm/groups (#26225)
  Regression: Meteor uses projection for its observes (#26223)
  Chore: Do not log integrations using `name` key (#26163)
  Chore: Check for env var values and not just if they are set (#26219)
  Regression: UIKit buttons auth user validation (#26171)
  Regression: Cannot logout when CallProvider is unregistered and mounted (#26158)
  Regression: Change Audio settings for device settings as modal title (#26159)
  Regression: Inline code and copyonly tag styles (#26173)
  Regression: remove italic from reaction translation (#26152)
  Regression: Reverting @rocket.chat/mp3-encoder version to fix Audio Message (#26197)
  Chore: Info page (#26201)
  Regression: Fix command previews (#26199)
  Change Apps-Engine version source for info (#26205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants