Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: VideoConference UX/UI Refactor 1st Interaction #26183

Merged
merged 17 commits into from
Jul 19, 2022

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jul 8, 2022

Given some user feedback, some changes were made to the initial design before the official release.
This pull request provides the suggested tweaks.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner July 8, 2022 00:41
@pierre-lehnen-rc pierre-lehnen-rc added this to the 5.0.0 milestone Jul 8, 2022
@pierre-lehnen-rc pierre-lehnen-rc changed the title [Improve] VideoConference Phase 1 [IMPROVE] VideoConference Phase 1 Jul 8, 2022
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner July 8, 2022 20:28
@ggazzo ggazzo changed the title [IMPROVE] VideoConference Phase 1 Chore: VideoConference Phase 2 Jul 18, 2022
ggazzo
ggazzo previously approved these changes Jul 18, 2022
@ggazzo ggazzo changed the title Chore: VideoConference Phase 2 Chore: VideoConference UX/IU Refactor 1st Interaction Jul 18, 2022
@dougfabris dougfabris changed the title Chore: VideoConference UX/IU Refactor 1st Interaction Chore: VideoConference UX/UI Refactor 1st Interaction Jul 18, 2022
d-gubert
d-gubert previously approved these changes Jul 19, 2022
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apps-Engine related changes are ok

@ggazzo ggazzo dismissed stale reviews from d-gubert and themself via 22ed6e9 July 19, 2022 13:38
ggazzo
ggazzo previously approved these changes Jul 19, 2022
d-gubert
d-gubert previously approved these changes Jul 19, 2022
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

dougfabris
dougfabris previously approved these changes Jul 19, 2022
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggazzo
Copy link
Member

ggazzo commented Jul 19, 2022

QA:

@janainaCoelhoRocketchat
Copy link
Contributor

just ended qa =)

@dougfabris dougfabris dismissed stale reviews from d-gubert, ggazzo, and themself via 8d14d5e July 19, 2022 19:34
@ggazzo
Copy link
Member

ggazzo commented Jul 19, 2022

image

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2022
@casalsgh casalsgh requested review from d-gubert and ggazzo July 19, 2022 20:39
@ggazzo ggazzo merged commit dfedda4 into develop Jul 19, 2022
@ggazzo ggazzo deleted the improve/videoconf-first-phase branch July 19, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants