Regression: Removed CE watermark from VoipFooter #26239
Conversation
| isEnterprise={isEnterprise} | ||
| options={options} |
There was a problem hiding this comment.
I purposely put this watermark there, in my view it makes no sense to remove the watermark, I will ask for an approver from the pm of digital workplace @milton-rucks
There was a problem hiding this comment.
I don't think we should have this distinction
There was a problem hiding this comment.
I've checked with Renato and Milton and they're aligned. This change is approved from Product. An important note here - the overlay of the watermark is temporary when ringer is displayed. The watermark is not being removed when VoIP is enabled.
|
I don't think we should remove this. |
|
I have updated the description of this pull request to clarify the intent and scope of this change. |
|
Now it makes more sense, I agree with the change. |
ggazzo
dismissed
tassoevan’s stale review
It still doesn't seem like the most wise decision to me, I promise that by the end of tomorrow (July 14th), I will have the answer I'm looking for. for now this pr will not be merged
|
Exceptional concern with product quality and consistency. Thank you for the quality and depth of the explanations, congratulations to those involved |
Proposed changes (including videos or screenshots)
The objective of this change is to remove the CE watermark only during an active call. The CE watermark will be displayed normally in all other scenarios. Bellow you can see a demonstration of the expected behavior:
Issue(s)
Steps to test or reproduce
Further comments