Chore: Fix services image publish do DockerHub #26608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #26608 +/- ##
===========================================
+ Coverage 38.54% 38.71% +0.17%
===========================================
Files 758 759 +1
Lines 18827 18834 +7
Branches 1453 1453
===========================================
+ Hits 7256 7292 +36
+ Misses 11355 11323 -32
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 18, 2022
murtaza98
pushed a commit
that referenced
this pull request
Aug 19, 2022
Merged
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This issue was caused by #25556 and since then Docker image for micro services are not being published with the correct tag. That means all 5.0.x releases don't have a published Docker image with the version tag.
The main was using
$IMAGE_TAGinstead of$DOCKER_TAGto publish the correct tag to DockerHub. I've changed the workflow do make the services publish to look similar to official one. Ideally they could be in a new action file.Issue(s)
Steps to test or reproduce
Further comments