Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Remove log from banners.ts #26699

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Regression: Remove log from banners.ts #26699

merged 1 commit into from
Aug 26, 2022

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner August 26, 2022 13:41
@ggazzo ggazzo changed the title Chore: Remove log from banners.ts Regression: Remove log from banners.ts Aug 26, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #26699 (8f0af0a) into develop (b2480ad) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26699      +/-   ##
===========================================
- Coverage    39.06%   39.02%   -0.05%     
===========================================
  Files          802      802              
  Lines        19056    19051       -5     
  Branches      1940     1939       -1     
===========================================
- Hits          7445     7435      -10     
- Misses       11324    11325       +1     
- Partials       287      291       +4     
Flag Coverage Δ
e2e 39.02% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 726d9f5 into develop Aug 26, 2022
@kodiakhq kodiakhq bot deleted the removeLog branch August 26, 2022 14:48
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants