[FIX] Remove contact mananger always to support old servers #27053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27053 +/- ##
===========================================
+ Coverage 40.22% 40.97% +0.75%
===========================================
Files 827 802 -25
Lines 18241 17810 -431
Branches 2020 1961 -59
===========================================
- Hits 7337 7298 -39
+ Misses 10609 10215 -394
- Partials 295 297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
murtaza98
approved these changes
Oct 12, 2022
ggazzo
added
stat: ready to merge
weslley543
pushed a commit
that referenced
this pull request
Oct 17, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 25, 2022
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
The way this issue was fixed did not take into consideration the posibility of a non-agent to be assigned as a contact manager (either intentional or by mistake) causing that references on visitor's collection won't be removed (since on delete, we only removed assignation from actual agent/monitors). This should fix that.
OC-243