Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Unify isLastDocDelayed logic #27120

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team October 21, 2022 13:27
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #27120 (6790d73) into develop (34ca34f) will increase coverage by 0.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27120      +/-   ##
===========================================
+ Coverage    40.55%   41.27%   +0.71%     
===========================================
  Files          828      803      -25     
  Lines        18254    17823     -431     
  Branches      2030     1971      -59     
===========================================
- Hits          7403     7356      -47     
+ Misses       10553    10174     -379     
+ Partials       298      293       -5     
Flag Coverage Δ
e2e 41.27% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 205a64c into develop Oct 21, 2022
@sampaiodiego sampaiodiego deleted the regression-unify-last-doc-logic branch October 21, 2022 15:45
gabriellsh added a commit that referenced this pull request Oct 31, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Unify isLastDocDelayed logic (#27120)
  [FIX] starting conferences with mic and cam on their default states do not sync the state with the provider (#26966)
  [NEW] Matrix federation events coverage expansion (adding support for 3 extra events) (#26859)
  Regression: Quote colors (#27110)
  Regression: Toolbox Divider Color (#27116)
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants