-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] Marketplace standalone page and app request flow #27389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved marketplace out of the views/admin folder. Currently it is rendering on the main layout of marketplace but it will get its own sidebar soon.
Codecov Report
@@ Coverage Diff @@
## develop #27389 +/- ##
============================================
+ Coverage 32.98% 44.93% +11.95%
============================================
Files 628 766 +138
Lines 12492 14893 +2401
Branches 1847 2067 +220
============================================
+ Hits 4120 6692 +2572
+ Misses 8164 7909 -255
- Partials 208 292 +84
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
requested changes
Dec 14, 2022
* refactor: ♻️ Change marketplace 'all' context to 'explore' context Changed the context that represents the all apps list from 'all' to 'context' in order for it to better represent the UI components under that route. * feat: ✨ Add redirect for users that access marketplace through the old 'all' context Added a redirect for users that try to access marketplace through the old route (/all/list) which can happen if someone bookmarked the old marketplace. * fix: 🐛 Fix what is it page behavior Fixed a problem in which the what is it page would constantly change betwwen the main marketplace page and itself because of some routing problems. * Add tab prop to AppRow route navigation function * Fix unit tests * Update apps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsx Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> * Lint * First review * Second review * use marketplace as route only * change function name * small adjustment Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
* feat: ✨ Implement new enterprise option in new marketplace sidebar Implemented a new option in the new marketplace that shows only enterprise apps. * fix: 🐛 Fix pagination bug Fixed a bug in which the pagination would show the wrong set of pages and total on the enterprise page. This bug happened because pagination was using the overall total number of apps, minus filtering, to calculate its total. Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
dougfabris
requested changes
Jan 11, 2023
d-gubert
previously approved these changes
Feb 17, 2023
KevLehman
previously approved these changes
Feb 17, 2023
ggazzo
force-pushed
the
feat/new-marketplace
branch
from
February 17, 2023 21:33
978aa38
to
77968f2
Compare
sampaiodiego
requested changes
Feb 17, 2023
sampaiodiego
approved these changes
Feb 18, 2023
d-gubert
approved these changes
Feb 18, 2023
KevLehman
approved these changes
Feb 18, 2023
ggazzo
approved these changes
Feb 18, 2023
apps/meteor/client/components/AdministrationList/AppsModelList.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
squad: apps ecosystem
AECO
squad: apps-engine
stat: ready to merge
PR tested and approved waiting for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Remove marketplace from the admin menu (on both the file system and the UI), change it into a standalone page, expose its use to end-users, and create an app request flow that allows end-users to ask for app installations in their workspaces directly through Rocket Chats UI.
Demo loom: https://www.loom.com/share/643ba3432225418e96c10041f386ff48
Jira tasks and ADRs
All tasks, descriptions, and designs of work done in this PR can be found on the tasks below, which also double down as simplified ADRs.
MKP-147 - Remove marketplace from the admin menu and put it on its own page
MKP-68 - Create an enterprise option on the new marketplace sidebar
MKP-150 - Implement the SideNav of the new marketplace page
MKP-151 - Brainstorm and implement the new marketplace routes
MKP-179 - Retrieve number of requested apps and make it available for components
MKP-181 - Implement requested option on marketplace sidebar
MKP-184 - Create requested apps page
MKP-185 - Implement requested apps list layout and logic
MKP-180 - Implement requested apps option to home screen kebab menu
MKP-188 - Implement the requested apps tab on app details page
MKP-187 - Implement visualized requests system on apps list tags and app requests tab
MKP-164 - ALL view the app's technical documentation page
MKP-197 - Rocket.cat notification for admins when an app is requested
MKP-224 - After i click submit request in the modal the modal is not closing
Issue(s)
Steps to test or reproduce
To test the exposed marketplace and end-user request flow:
E.G.:
yarn dev
To test the admin request flow and request visualization system:
Further comments