Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: message box issues #27495

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Regression: message box issues #27495

merged 3 commits into from
Dec 8, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It fixes some problems introduced/exposed after refactoring the ChatMessages API.

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #27495 (0d62855) into develop (557708a) will increase coverage by 0.96%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27495      +/-   ##
===========================================
+ Coverage    41.13%   42.09%   +0.96%     
===========================================
  Files          846      819      -27     
  Lines        18378    17860     -518     
  Branches      2101     2025      -76     
===========================================
- Hits          7560     7519      -41     
+ Misses       10534    10057     -477     
  Partials       284      284              
Flag Coverage Δ
e2e 42.09% <70.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review December 8, 2022 17:36
@ggazzo ggazzo merged commit 631e5c0 into develop Dec 8, 2022
@ggazzo ggazzo deleted the regression/message-box branch December 8, 2022 18:14
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants