Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Implement Queue service #27531

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Dec 13, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-496
OC-497
OC-498

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #27531 (f9441a0) into feat/chat-transcript (37bb9c9) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/chat-transcript   #27531      +/-   ##
========================================================
- Coverage                 41.09%   41.02%   -0.07%     
========================================================
  Files                       845      845              
  Lines                     18291    18291              
  Branches                   2078     2078              
========================================================
- Hits                       7516     7504      -12     
- Misses                    10504    10516      +12     
  Partials                    271      271              
Flag Coverage Δ
e2e 41.02% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from chore/create-services to feat/chat-transcript December 14, 2022 15:34
@KevLehman KevLehman requested a review from a team as a code owner December 14, 2022 15:34
export type HealthAggResult = {
total: number;
type: string;
status: 'Rejected' | 'In progress';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this enum pls? Just to avoid typo's

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos would produce a type error anyways, but i can make it 👀

@filipemarins filipemarins force-pushed the feat/chat-transcript branch 2 times, most recently from 99d1440 to af3ec69 Compare December 16, 2022 18:15
@filipemarins filipemarins requested review from a team as code owners December 16, 2022 18:15
@KevLehman KevLehman merged commit 31952b1 into feat/chat-transcript Dec 22, 2022
@KevLehman KevLehman deleted the new/queue-service-base branch December 22, 2022 16:17
filipemarins pushed a commit that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants