Chore: Move service definitions to core services package #27546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27546 +/- ##
===========================================
+ Coverage 42.46% 43.71% +1.25%
===========================================
Files 839 812 -27
Lines 17695 17176 -519
Branches 1977 1902 -75
===========================================
- Hits 7514 7509 -5
+ Misses 9929 9416 -513
+ Partials 252 251 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
ggazzo
requested changes
Dec 19, 2022
sampaiodiego
changed the title
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
reviewed
Dec 23, 2022
| @@ -4,11 +4,11 @@ import type { IMessage } from '@rocket.chat/apps-engine/definition/messages'; | |||
| import type { IUser } from '@rocket.chat/apps-engine/definition/users'; | |||
| import type { IRoom } from '@rocket.chat/apps-engine/definition/rooms'; | |||
| import type { ISubscription } from '@rocket.chat/core-typings'; | |||
| import { api } from '@rocket.chat/core-services'; | |||
There was a problem hiding this comment.
🤔 I'm voting for renaming api to core.
…itions-to-core-sdk-package
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
Dec 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-118
Steps to test or reproduce
Further comments
There are a few things missing:
StreamerCentraltoLocalBrokervia dependency injectionapiexport fromapps/meteor/server/sdk/api.tsgetRoutingManagerConfigwas removed, check if it was really not being usedpackages/core-sdk/src/types/IVoipService.tscheck howgetConnector()is used and figure how to fix it out